Page MenuHomeFreeBSD

Testing flavors with PHP modules
Needs RevisionPublic

Authored by daniel_blodan.se on Sep 29 2017, 1:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Aug 9 2025, 11:24 PM
Unknown Object (File)
Aug 2 2025, 9:57 AM
Unknown Object (File)
Jun 21 2025, 12:30 AM
Unknown Object (File)
May 21 2025, 10:28 AM
Unknown Object (File)
May 17 2025, 3:47 AM
Unknown Object (File)
May 12 2025, 8:30 PM
Unknown Object (File)
May 7 2025, 7:11 PM
Unknown Object (File)
Apr 10 2025, 10:07 AM
Subscribers
None

Details

Reviewers
bapt
mat
bdrewery
Summary

I know flavors isn't production ready yet, but I'm just giving it a whirl to find any issues.

Would this be the correct way of implementing flavors for php modules?

The only two issues I am getting are these:

  • make config options does not get stored

ie, when i run make FLAVOR=70 I'm getting prompted about the make config everytime even though I already configured the port and that particular flavor

  • The prefix doesn't seem to get applied, running make clean after building all 3 flavors yields this output:
===>  Cleaning for pecl-redis-3.1.4
===>  Cleaning for pecl-redis-3.1.4
===>  Cleaning for pecl-redis-3.1.4

As if all 3 flavors are named the same thing

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bapt requested changes to this revision.Oct 5 2017, 3:00 PM

except that one is not allowed to play with DEFAULT_VERSION, this particular case of pecl should lead to work in MK/Uses/php.mk as well.

DEFAULT_VERSIONS is something that should only be for end users.

The approach is the right one

This revision now requires changes to proceed.Oct 5 2017, 3:00 PM