Page MenuHomeFreeBSD

Disable/Enable CSUM_UDP and CSUM_TCP along with CSUM_IP for if_awg
ClosedPublic

Authored by guyyur_gmail.com on Sep 28 2017, 6:22 PM.

Details

Summary

When changing IFCAP_TXCSUM for if_awg set/clear hw assist bits for CSUM_IP, CSUM_UDP, CSUM_TCP not just CSUM_IP.
The card cannot handle just tcp/udp checksums it can only calculate ip checksums or full checksums (ip and tcp/udp).

Also don't consider IFCAP_RXCSUM for setting clearing the bits.
The CSUM_ flags in hw assist bits are only relevant for the tx path.
The rx path already checks IFCAP_RXCSUM to know if to fill in the checksums calculated by the card.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmcneill accepted this revision.Sep 30 2017, 10:13 AM
This revision is now accepted and ready to land.Sep 30 2017, 10:13 AM
This revision was automatically updated to reflect the committed changes.