Page MenuHomeFreeBSD

New port: sysutils/puppetserver5
ClosedPublic

Authored by zleslie on Sep 27 2017, 3:59 AM.
Tags
None
Referenced Files
F109565142: D12513.diff
Thu, Feb 6, 7:01 PM
Unknown Object (File)
Dec 16 2024, 6:19 PM
Unknown Object (File)
Dec 12 2024, 9:39 AM
Unknown Object (File)
Nov 29 2024, 2:19 PM
Unknown Object (File)
Nov 25 2024, 12:19 AM
Unknown Object (File)
Nov 19 2024, 12:00 AM
Unknown Object (File)
Sep 22 2024, 5:28 AM
Unknown Object (File)
Sep 17 2024, 11:07 PM
Subscribers
None

Details

Summary

This port is based on prior wor done in sysutils/puppetserver, and updated to
leverage the CFACTER build of sysutils/facter.

Test Plan

I've run this through poudriere testport and verified that the
service starts correctly with both CFACTER and RFACTER.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

puppetserver5/Makefile
52–57 ↗(On Diff #33477)

It would probably be better to fix all those in one go.

@${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|' \
    -e 's|%%RUBY_SITELIBDIR%%|${RUBY_SITELIBDIR}|' \
    -e 's|%%RUBY_VER%%|${RUBY_VER}|' \
    -e 's|%%JAVA%%|${JAVA}|' \
    -e 's|%%ETCDIR%%|${ETCDIR}|' \
    -e 's|%%DATADIR%%|${DATADIR}|' \
    ${WRKSRC}/${file}

Also, use single quotes, not double quotes.

And then, you could pass all the files at once and run sed only once.

62 ↗(On Diff #33477)

This one is not needed, MKDIR will create directories recursively.

puppetserver5/files/patch-ext__bin__puppetserver
4–5 ↗(On Diff #33477)

This should be fixed with USES=shebangfix.

puppetserver5/files/pkg-message.in
1 ↗(On Diff #33477)
Remember to run:

sysrc puppetserver_enable=yes

I believe I've addressed all the feedback.

Is anything else required here for me to commit?

This revision is now accepted and ready to land.Oct 3 2017, 1:06 PM
This revision was automatically updated to reflect the committed changes.
head/sysutils/puppetserver5/Makefile
14

Too early.