Page MenuHomeFreeBSD

New port: sysutils/puppetserver5
ClosedPublic

Authored by zleslie on Sep 27 2017, 3:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 15 2024, 1:17 AM
Unknown Object (File)
Jan 14 2024, 11:09 PM
Unknown Object (File)
Dec 24 2023, 5:00 PM
Unknown Object (File)
Dec 20 2023, 4:46 AM
Unknown Object (File)
Nov 26 2023, 4:34 PM
Unknown Object (File)
Nov 24 2023, 1:08 PM
Unknown Object (File)
Nov 24 2023, 1:13 AM
Unknown Object (File)
Nov 23 2023, 7:51 PM
Subscribers
None

Details

Summary

This port is based on prior wor done in sysutils/puppetserver, and updated to
leverage the CFACTER build of sysutils/facter.

Test Plan

I've run this through poudriere testport and verified that the
service starts correctly with both CFACTER and RFACTER.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

puppetserver5/Makefile
52–57 ↗(On Diff #33477)

It would probably be better to fix all those in one go.

@${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|' \
    -e 's|%%RUBY_SITELIBDIR%%|${RUBY_SITELIBDIR}|' \
    -e 's|%%RUBY_VER%%|${RUBY_VER}|' \
    -e 's|%%JAVA%%|${JAVA}|' \
    -e 's|%%ETCDIR%%|${ETCDIR}|' \
    -e 's|%%DATADIR%%|${DATADIR}|' \
    ${WRKSRC}/${file}

Also, use single quotes, not double quotes.

And then, you could pass all the files at once and run sed only once.

62 ↗(On Diff #33477)

This one is not needed, MKDIR will create directories recursively.

puppetserver5/files/patch-ext__bin__puppetserver
4–5 ↗(On Diff #33477)

This should be fixed with USES=shebangfix.

puppetserver5/files/pkg-message.in
1 ↗(On Diff #33477)
Remember to run:

sysrc puppetserver_enable=yes

I believe I've addressed all the feedback.

Is anything else required here for me to commit?

This revision is now accepted and ready to land.Oct 3 2017, 1:06 PM
This revision was automatically updated to reflect the committed changes.
head/sysutils/puppetserver5/Makefile
14

Too early.