Page MenuHomeFreeBSD

new port: games/nxengine (Cave Story)
ClosedPublic

Authored by lifanov on Sep 12 2017, 1:35 AM.

Details

Summary
This port contains all you need to play Cave Story.

Inspiration for symlinking nx to home directory was
taken from Arch Linux PKGBUILD.
Test Plan
poudriere testport - OK
gameplay - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lifanov created this revision.Sep 12 2017, 1:35 AM
matthew added inline comments.Sep 12 2017, 5:50 AM
games/nxengine/files/nxengine.in
5 ↗(On Diff #32943)

The construct "$HOME"/.nxengine looks odd to me -- most people would write that as
"${HOME}/.nxengine"

9 ↗(On Diff #32943)

Why is this in a subshell? The wrapper script doesn't do anything other than start
up the game. Why not something like this?

cd "${HOME}/.nxengine"
exec ./nx "$@"
lifanov updated this revision to Diff 32964.Sep 12 2017, 1:16 PM

address matthew's feedback: good point about just exec'ing nx

As for "$HOME"/.nxengine, I prefer this form for efficiency.
There is a whole lot of stuff curly brace expansion does and
in this case we don't use any of it. Likewise, I use double quotes
on just the shortest substring I want double quote expansion on.

If this is strage or hard to read, I'll change it.

lifanov updated this revision to Diff 32965.Sep 12 2017, 1:17 PM

whoops, lost a path component

lifanov updated this revision to Diff 32975.Sep 12 2017, 3:34 PM

o unhardcode some values having to do with DISTFILES
o be more precise in the LICENSE block about which license applies to what

swills added inline comments.Sep 14 2017, 3:34 PM
games/nxengine/Makefile
25 ↗(On Diff #32975)

License stuff looks fine.

37 ↗(On Diff #32975)

I won't reject for this, but I really wish people would do this kind of "patch via sed" less. It makes it easy for this kind of thing to go unnoticed if it happens to be come unnecessary. I've seen a number of these end up still in place ages after they were no longer needed and functionally useless. Also, it makes it almost impossible to submit to upstream or for upstream to even see what changes we're making if they did happen to look for patches.

40 ↗(On Diff #32975)

I think we want to not mute this?

lifanov updated this revision to Diff 33081.Sep 14 2017, 5:27 PM

address swills' feedback:

migrate from "use sed to patch" to patch files for finding <sys/endian.h>
unmute DATADIR creation

This revision was automatically updated to reflect the committed changes.