[NEW PORT] graphics/py-graphviz: Simple Python interface for Graphviz This package facilitates the creation and rendering of graph descriptions in the DOT language of the Graphviz graph drawing software (repo) from Python. Create a graph object, assemble the graph by adding nodes and edges, and retrieve its DOT source code string. Save the source code to a file and render it with the Graphviz installation of your system. Use the view option/method to directly inspect the resulting (PDF, PNG, SVG, etc.) file with its default application. Graphs can also be rendered and displayed within Jupyter notebooks (a.k.a. IPython notebooks, example) as well as the Jupyter Qt Console. WWW: https://github.com/xflr6/graphviz Already existed a port named graphics/py-graphviz, it was moved in ports r408353 to graphics/py-pygraphviz because it was using an incorrect name. More info in the commit log [1]. 1 - https://svnweb.freebsd.org/ports?view=revision&revision=408353 PR: 222205 Reviewed by: koobs, ??? Submitted by: lbartoletti@tuxfamily.org Differential Revision: D12319
Details
Already existed a port named graphics/py-graphviz, it was moved in
ports r408353 to graphics/py-pygraphviz because it was using an
incorrect name. More info in the commit log.
I want to be sure about the change in the MOVED file.
There is no mention about this in the PH 10.2.2. /usr/ports/MOVED
Thanks.
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Removing a MOVED entry for a re-added (resurrected) port is standard/expected.
However, for cases where the re-added package is not the same software as was provided prior to deletion, there is no mechanism that I know of in the ports framework (policy or otherwise) to ensure that users that might still have the old port/package installed wont have it replaced with the later (newer, re-added) one once its re-added.
Having said that, waiting a sufficient amount of time minimises this risk. The original graphics/py-graphviz port was deleted 18 months ago, which I would consider enough time.
Note: I have had this problem with the (incorrectly named, now deleted) net/py-twitter port, when I was porting the PyPI twitter package, which I committed as net/py-twitter-tools until a sufficient amount of time passed. I still haven't moved it to its proper place/name :)
No mention of QA tests (portlint, poudriere) results in TEST PLAN, please add these.
Also, for python packages that provide tests (this one does), add TEST_DEPENDS and a do-test: target to run them where possible, even if they don't all pass.
See: https://github.com/xflr6/graphviz/blob/master/.travis.yml#L18-L19 (only add packages *required* to run the tests, which probably doesnt include coveralls)
Add test target, it's needed a new dependency (devel/py-pytest-cov).
Add Python concurrent.
============================================================================ test session starts ============================================================================ platform freebsd12 -- Python 2.7.13, pytest-3.2.1, py-1.4.34, pluggy-0.4.0 rootdir: /usr/home/dbaio/FreeBSD/ports_head/graphics/py-graphviz/work/graphviz-0.8, inifile: setup.cfg plugins: mock-1.6.2, cov-2.5.1 collected 80 items README.rst . docs/manual.rst . graphviz/__init__.py . graphviz/dot.py . graphviz/lang.py .... graphviz/tools.py .. tests/test_backend.py ........................ tests/test_dot.py ...................... tests/test_files.py .................. tests/test_lang.py .... tests/test_tools.py .. -------- coverage: platform freebsd12, python 2.7.13-final-0 --------- Name Stmts Miss Cover ------------------------------------------ graphviz/__init__.py 13 0 100% graphviz/_compat.py 3 0 100% graphviz/backend.py 82 0 100% graphviz/dot.py 111 0 100% graphviz/files.py 113 0 100% graphviz/lang.py 39 0 100% graphviz/tools.py 17 0 100% ------------------------------------------ TOTAL 378 0 100% Coverage HTML written to dir cover ========================================================================= 80 passed in 1.80 seconds =========================================================================
$ portlint -CA looks fine.
poudriere OK with Python 2.7 and 3.6.
10.3-RELEASE-p21 amd64
10.3-RELEASE-p21 i386
11.1-RELEASE-p1 amd64
11.1-RELEASE-p1 i386
12.0-CURRENT 1200044 amd64
12.0-CURRENT 1200044 i386
Always add test/QA results to TEST PLAN (so people don't need to go searching for them)
Otherwise, changes look OK