Page MenuHomeFreeBSD

net-im/mastodon: Working port that handles node modules and assets
ClosedPublic

Authored by jrm on Sep 10 2017, 4:25 PM.

Details

Summary

With these changes, users can just install the package without having to run any extra steps afterwards that generate many files not accounted for by the package. All files are installed under WWWDIR.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11581
Build 11934: arc lint + arc unit

Event Timeline

jrm created this revision.Sep 10 2017, 4:25 PM

Is asset generation working during the build stage? If yes, I think we can get rid of most node_modules - most importantly we can discard node-sass.

jrm added a comment.Sep 10 2017, 5:28 PM

Yes, it's working.

jrm updated this revision to Diff 32890.Sep 10 2017, 5:29 PM

Do not hardcode NODE_ABI

jrm added inline comments.Sep 10 2017, 7:13 PM
net-im/mastodon/Makefile
104–105

This is bad. Is there a reasonable way to get the installed NODE_MODULE_ABI?

108–116

This prevents the problem with not cleaning WRKDIR, but is also obviously bad, because ${DISTDIR}/${PORTNAME}-npm/node_modules might be from a previous build.

jrm updated this revision to Diff 33093.Sep 15 2017, 1:26 AM

Use an offline mirror to build the node modules

jrm marked 2 inline comments as done.Sep 15 2017, 1:28 AM
jrm updated this revision to Diff 33097.Sep 15 2017, 3:52 AM

Handle node abi in pkg-plist and include changes to dependent ports

jrm retitled this revision from net-im/mastodon: searching for least evil way to fetch/build node modules to net-im/mastodon: Working port that handles node modules and assets.Sep 15 2017, 3:55 AM
jrm edited the summary of this revision. (Show Details)
mat added inline comments.Sep 15 2017, 9:39 AM
converters/rubygem-json-ld/Makefile
5

DISTVERSION.

17–20

bad ordering.

devel/rubygem-paperclip-rails5/Makefile
21–22

should be later.

textproc/rubygem-iso-639/Makefile
5

DISTVERSION

16

bad ordering.

www/rubygem-rdf-normalize/Makefile
5

DISTVERSION.

16

Bar ordering.

jrm updated this revision to Diff 33101.Sep 15 2017, 9:57 AM

Use DISTVERSION instead of PORTVERSION and fix ordering

jrm marked 6 inline comments as done.Sep 15 2017, 9:59 AM
jrm marked an inline comment as done.
jrm accepted this revision.Sep 15 2017, 11:01 PM
This revision is now accepted and ready to land.Sep 15 2017, 11:01 PM
jrm closed this revision.Sep 15 2017, 11:01 PM