Honor all options of "zfs mount -o"
ClosedPublic
Actions

Authored by asomers on Sep 5 2017, 6:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 11, 9:55 AM

	Unknown Object (File)
	Wed, Mar 11, 5:59 AM

	Unknown Object (File)
	Fri, Mar 6, 7:24 PM

	Unknown Object (File)
	Fri, Mar 6, 7:43 AM

	Unknown Object (File)
	Fri, Mar 6, 1:25 AM

	Unknown Object (File)
	Wed, Feb 18, 8:34 PM

	Unknown Object (File)
	Tue, Feb 17, 6:30 AM

	Unknown Object (File)
	Feb 8 2026, 11:44 AM

View All Files

Subscribers

imp

Details

Reviewers

avg

Commits

rS326327: MFC r323193:
rS324061: MFC r323193:
rS323193: Honor all options of "zfs mount -o"

Summary

Honor all options of "zfs mount -o"

The existing code in zmount incorrectly parses the comma-delimited option
string. The result is that nmount only honors the last option. AFAICT the
parsing has been broken ever since ZFS's initial import in change 168404.

PR: 222078

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Sep 5 2017, 6:50 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 5 2017, 6:50 PM

Harbormaster completed remote builds in B11374: Diff 32674.Sep 5 2017, 6:50 PM

LGTM.

This revision is now accepted and ready to land.Sep 5 2017, 7:22 PM

Closed by commit rS323193: Honor all options of "zfs mount -o" (authored by asomers). · Explain WhySep 5 2017, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

cddl/

compat/

opensolaris/

misc/

zmount.c

12 lines

Diff 32678

View Options

head/cddl/compat/opensolaris/misc/zmount.c

Honor all options of "zfs mount -o"ClosedPublicActions