New port: devel/yaml2argdata.
ClosedPublic
Actions

Authored by ed on Aug 30 2017, 1:41 PM.

Details

Reviewers

koobs
mat

Commits

rP449342: New port: devel/yaml2argdata.

Summary

The latest release of cloudabi-utils has cloudabi-run rewritten from C
into C++. It now also has integrated support for attaching processes to
CloudABI's networking daemon, Flower.

In the process, code specific to parsing YAML configuration files
describing process configuration and resource dependencies has been
placed into a separate library, called yaml2argdata. This has the
advantage that this code can now be used by CloudABI's Kubernetes daemon
as well. Add a package for it, so sysutils/cloudabi-utils can make use
of it when we bump it.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed created this revision.Aug 30 2017, 1:41 PM

Friendly ping. :-)

mat added inline comments.Sep 6 2017, 10:05 AM

devel/yaml2argdata/Makefile
5 ↗	(On Diff #32518)	There should be tab between `=` and `v`, one can never be sure with phabricator if it is missing or just very thin.
24–25 ↗	(On Diff #32518)	Never, ever, use CP to install files. ${MKDIR} ${STAGEDIR}${LOCALBASE}/include/${PORTNAME} cd ${WRKSRC}/${PORTNAME} && ${COPYTREE_SHARE} . ${STAGEDIR}${LOCALBASE}/include/${PORTNAME}

Process mat@'s feedback.

Harbormaster completed remote builds in B11391: Diff 32707.Sep 6 2017, 10:43 AM

ed added inline comments.Sep 6 2017, 10:43 AM

devel/yaml2argdata/Makefile
24–25 ↗	(On Diff #32518)	Thanks! Due to its name (`COPYTREE_SHARE`), I wasn't sure whether I could also use this for files under include/, as opposed to share/.

mat added inline comments.Sep 6 2017, 10:50 AM

devel/yaml2argdata/Makefile
24–25 ↗	(On Diff #32518)	Oh, well, maybe it is a bit mis-named, what it mostly mean is that it installs stuff as 644 and not as executable.
24–25 ↗	(On Diff #32518)	Drat, I missed it. replace LOCALBASE with PREFIX here.