Page MenuHomeFreeBSD

databases/influxdb: Update to 1.3.3
ClosedPublic

Authored by ultima on Aug 24 2017, 8:07 PM.

Details

Summary
  • Updated to 1.3.3
  • Cleanup Makefile
  • Removed STRIP var, stripping go is always safe[1].

[1] https://dominik.honnef.co/posts/2016/10/go-and-strip/

PR\: 221561
Submitted by\: Ari Suutari
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor), cheffo (maintainer)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: Makefile: possible use of absolute pathname "/var/db/${PORTNAME}/".
WARN: Makefile: possible use of absolute pathname "/var/log/${PORTNAME}...".
WARN: Makefile: possible use of absolute pathname "/var/run/${PORTNAME}...".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 5 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ultima created this revision.Aug 24 2017, 8:07 PM

An attempt was made to clean up the bottom targets. It is a mess, but I came to the conclusion that it should be left alone...

matthew requested changes to this revision.Aug 24 2017, 9:50 PM

LICENSE_FILE appears to be missing?

===> Staging rc.d startup script(s)
install: /wrkdirs/usr/ports/databases/influxdb/work/influxdb-1.3.3/LICENSE: No such file or directory
*** Error code 71

Stop.
make: stopped in /usr/ports/databases/influxdb
build of databases/influxdb | influxdb-1.3.3 ended at Thu Aug 24 22:46:57 BST 2017
build time: 00:02:19
!!! build failure encountered !!!
This revision now requires changes to proceed.Aug 24 2017, 9:50 PM
ultima updated this revision to Diff 32375.Aug 24 2017, 10:38 PM
ultima edited edge metadata.
  • Fixed item (I think)?

LICENSE_FILE appears to be missing?

===> Staging rc.d startup script(s)
install: /wrkdirs/usr/ports/databases/influxdb/work/influxdb-1.3.3/LICENSE: No such file or directory
*** Error code 71

Stop.
make: stopped in /usr/ports/databases/influxdb
build of databases/influxdb | influxdb-1.3.3 ended at Thu Aug 24 22:46:57 BST 2017
build time: 00:02:19
!!! build failure encountered !!!

It seems that the devel poudriere is more sensitive. I think what was happening is the LICENSE file being moved out of the directory after the LICENSE_FILE check that ports-mgmt does.

mat added inline comments.Aug 24 2017, 10:59 PM
databases/influxdb/Makefile
16 ↗(On Diff #32375)

This port does not use *any* of the USES=go features (build and install) I do not think it should use USES=go at all, it should keep the BUILD_DEPENDS it had before.

ultima updated this revision to Diff 32377.Aug 24 2017, 11:08 PM
  • Reverted USES= go
This revision is now accepted and ready to land.Aug 25 2017, 6:10 AM
This revision was automatically updated to reflect the committed changes.