Add a package for ARPC.
ClosedPublic
Actions

Authored by ed on Aug 22 2017, 3:52 PM.

Details

Reviewers

beat
riggs

Commits

rP449385: Add a package for ARPC.

Summary

ARPC is an RPC library similar to GRPC. Though a lot simpler than GRPC
featurewise, it has transparent support for file descriptor passing.
ARPC is used by some applications related to CloudABI, like Flower
(CloudABI's networking daemon).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed created this revision.Aug 22 2017, 3:52 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 22 2017, 3:52 PM

Harbormaster completed remote builds in B11203: Diff 32323.Aug 22 2017, 3:52 PM

mat added inline comments.Aug 22 2017, 6:42 PM

devel/arpc/Makefile
6 ↗	(On Diff #32323)	missing a tab after the =. Also, you should probably be using DISTVERSION and not PORTVERSION.
19 ↗	(On Diff #32323)	LIB_DEPENDS should be before RUN_DEPENDS.
24 ↗	(On Diff #32323)	This should go before USE_GITHUB
27–28 ↗	(On Diff #32323)	USES=localbase

Process feedback provided by mat@.

Harbormaster completed remote builds in B11204: Diff 32326.Aug 22 2017, 7:02 PM

Thanks for the feedback. Really appreciated!

Looks good!

Minor thing: If you don't expect the plist to become larger soon, I'd probably follow portlint's recommendation to use PLIST_FILES inside the Makefile rather than having pkg-plist.

This revision is now accepted and ready to land.Sep 2 2017, 4:50 PM

In D12103#253343, @riggs wrote:

Minor thing: If you don't expect the plist to become larger soon, I'd probably follow portlint's recommendation to use PLIST_FILES inside the Makefile rather than having pkg-plist.

That sounds like a good idea, as I don't expect the plist to grow for now. I'll commit a version of the port that uses PLIST_FILES.

Closed by commit rP449385: Add a package for ARPC. (authored by ed). · Explain WhySep 7 2017, 5:53 AM

This revision was automatically updated to reflect the committed changes.