Page MenuHomeFreeBSD

Add a package for ARPC.
ClosedPublic

Authored by ed on Aug 22 2017, 3:52 PM.

Details

Summary

ARPC is an RPC library similar to GRPC. Though a lot simpler than GRPC
featurewise, it has transparent support for file descriptor passing.
ARPC is used by some applications related to CloudABI, like Flower
(CloudABI's networking daemon).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

devel/arpc/Makefile
6 ↗(On Diff #32323)

missing a tab after the =. Also, you should probably be using DISTVERSION and not PORTVERSION.

19 ↗(On Diff #32323)

LIB_DEPENDS should be before RUN_DEPENDS.

24 ↗(On Diff #32323)

This should go before USE_GITHUB

27–28 ↗(On Diff #32323)

USES=localbase

Process feedback provided by mat@.

ed marked 4 inline comments as done.Aug 22 2017, 7:03 PM

Thanks for the feedback. Really appreciated!

Looks good!

Minor thing: If you don't expect the plist to become larger soon, I'd probably follow portlint's recommendation to use PLIST_FILES inside the Makefile rather than having pkg-plist.

This revision is now accepted and ready to land.Sep 2 2017, 4:50 PM

Minor thing: If you don't expect the plist to become larger soon, I'd probably follow portlint's recommendation to use PLIST_FILES inside the Makefile rather than having pkg-plist.

That sounds like a good idea, as I don't expect the plist to grow for now. I'll commit a version of the port that uses PLIST_FILES.

This revision was automatically updated to reflect the committed changes.