Differential D11911

apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase
ClosedPublic
Actions

Authored by royger on Aug 7 2017, 10:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 28, 5:45 AM

	Unknown Object (File)
	Thu, Jun 26, 11:28 PM

	Unknown Object (File)
	Wed, Jun 25, 4:06 PM

	Unknown Object (File)
	Tue, Jun 24, 11:23 AM

	Unknown Object (File)
	Sun, Jun 22, 5:25 PM

	Unknown Object (File)
	Sun, Jun 22, 1:47 PM

	Unknown Object (File)
	Tue, Jun 17, 12:50 AM

	Unknown Object (File)
	Sun, Jun 15, 8:56 PM

View All 61 Files

Subscribers

None

Details

Reviewers

kib
jhb

Commits

rS322347: apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase

Summary

Populate the lapics arrays and call cpu_add/lapic_create in the setup
phase instead. Also store the max APIC ID found in the newly
introduced max_apic_id global variable.

This is a requirement in order to make the static arrays currently
using MAX_LAPIC_ID dynamic.

Sponsored by: Citrix Systems R&D

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger created this revision.Aug 7 2017, 10:23 AM

Harbormaster completed remote builds in B10920: Diff 31698.Aug 7 2017, 10:23 AM

kib accepted this revision.Aug 7 2017, 11:09 AM

kib added inline comments.

sys/x86/include/apicvar.h
178 ↗	(On Diff #31698)	Add this to x86/include/x86_var.h ?
sys/x86/x86/mptable.c
480 ↗	(On Diff #31698)	I think that xAPIC constant should be used for mptable configs.

This revision is now accepted and ready to land.Aug 7 2017, 11:09 AM

Thanks.

sys/x86/x86/mptable.c
480 ↗	(On Diff #31698)	MAX_LAPIC_ID is set to 63 or 11 on the top of the file. I'm not sure it safe to expand it to 254 (xAPIC_MAX_APIC_ID).

Closed by commit rS322347: apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase (authored by royger). · Explain WhyAug 10 2017, 9:15 AM

This revision was automatically updated to reflect the committed changes.

royger marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

head/

sys/

x86/

acpica/

34 lines

1 line

include/

1 line

x86/

1 line

4 lines

37 lines

xen/

18 lines

Diff 31858

head/sys/x86/acpica/madt.c

Loading...

head/sys/x86/acpica/srat.c

Loading...

head/sys/x86/include/x86_var.h

Loading...

head/sys/x86/x86/local_apic.c

Loading...

head/sys/x86/x86/mp_x86.c

Loading...

head/sys/x86/x86/mptable.c

Loading...

head/sys/x86/xen/pvcpu_enum.c

Loading...