Page MenuHomeFreeBSD

textproc/fzf: Add shell examples directory
ClosedPublic

Authored by ultima on Aug 6 2017, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 29 2024, 6:35 AM
Unknown Object (File)
Jan 29 2024, 6:35 AM
Unknown Object (File)
Jan 29 2024, 6:34 AM
Unknown Object (File)
Jan 29 2024, 6:30 AM
Unknown Object (File)
Jan 27 2024, 5:15 PM
Unknown Object (File)
Dec 25 2023, 4:35 AM
Unknown Object (File)
Dec 20 2023, 7:06 AM
Unknown Object (File)
Nov 18 2023, 6:42 AM
Subscribers

Details

Summary
  • Bump revision
  • Removed strip, stripping go is safe
  • Added examples

PR\: 221113
Submitted by\: Sascha Holzleiter <sascha@root-login.org> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I hope the summary is not what the commit message will be. Commit messages should be about why things are happening, not what you are doing. Here, something like "Stripping go binaries is fine and add examples" would be more like it. (Also, double negatives are a no.)

textproc/fzf/Makefile
30–32 ↗(On Diff #31638)

PORTEXAMPLES only works when there is an EXAMPLES option.

ultima edited the summary of this revision. (Show Details)

(you still need to define an EXAMPLES option.)

This revision is now accepted and ready to land.Aug 8 2017, 7:13 PM
This revision was automatically updated to reflect the committed changes.