Page MenuHomeFreeBSD

[NEW PORT] archivers/c-blosc: Blocking, shuffling and loss-less compression library
ClosedPublic

Authored by ultima on Aug 5 2017, 11:08 PM.
Tags
None
Referenced Files
F84870115: D11889.diff
Wed, May 29, 3:17 PM
F84818250: D11889.id31728.diff
Tue, May 28, 11:40 PM
Unknown Object (File)
Sun, May 26, 10:31 PM
Unknown Object (File)
Sun, May 26, 10:31 PM
Unknown Object (File)
Sun, May 26, 10:31 PM
Unknown Object (File)
Tue, May 14, 12:35 PM
Unknown Object (File)
Sun, May 5, 6:25 AM
Unknown Object (File)
Sun, May 5, 3:28 AM
Subscribers

Details

Summary

Blosc is a high performance compressor optimized for binary data.
It has been designed to transmit data to the processor cache faster
than the traditional, non-compressed, direct memory fetch approach
via a memcpy() OS call. Blosc is the first compressor (that I'm aware of)
that is meant not only to reduce the size of large datasets on-disk or
in-memory, but also to accelerate memory-bound computations.

WWW: http://blosc.org/

PR\: 220908
Submitted by\: Iblis Lin <iblis@hs.ntnu.edu.tw> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10889
Build 11279: arc lint + arc unit

Event Timeline

archivers/Makefile
17–18

I'm not sure if special characters are sorted before or after alpha.

  • Fix for tests on 103amd64/i386
archivers/Makefile
17–18

The ordering is like so:

foo
foo-bar
foo-baz
foobar

so what you have here is correct. In any case, you can use the addport.sh script to add a new port, and it will insert entries in the category makefile in the correct
order.

archivers/Makefile
17–18

We use the C ordering, so, LANG=C sort. Best would be to use the addport script to add ports, so you do not have to think about these things.

archivers/c-blosc/Makefile
20

Default, remove.

28
USE_STDC= c11
34–35

I think all of those could be simplified with doing:

STATIC_CMAKE_BOOL= BUILD_STATIC
archivers/c-blosc/Makefile
28

Oops, I get it wrong half the time:

USE_CSTD= c11

Yeah, I have been using the addport script. Just not sure if this should be added to the diff as well, I guess not.

archivers/c-blosc/Makefile
28

Got it, btw why doesn't compiler:c11 set this automagically? I can't see a good reason for requesting a standards and not also enforcing it as the USES does here. What am I missing?

34–35

Will fix and verify.

archivers/c-blosc/Makefile
28

Because they are not the same thing.

  • compiler:c11 means I need a compiler that understands c11
  • -std=c11 means that the code is written according to the c11 syntax.

You can write C code using, say, the c99 syntax and using some c11 features, and you can write code that uses the c11 syntax and only uses basic features from the k&r times.

archivers/c-blosc/Makefile
28

That makes sense, I am still learning C, understand the basics but don't know many of the libraries. Don't understand the difference in standards had thought the newer standards just added headers for new functions in the core language. Thanks for explanation.

Removed GH_PROJECT, Added USE_CSTD= c11, optimised option helpers

archivers/c-blosc/Makefile
34–35

Most of them are backwards, on is off and off is on so that can't utilize the _bool option helper.

Added the double negative option helper

This revision is now accepted and ready to land.Aug 8 2017, 10:06 PM
This revision was automatically updated to reflect the committed changes.