Page MenuHomeFreeBSD

Fix off by one in calculation of the number of buckets for the pc addresses.
ClosedPublic

Authored by kib on Aug 4 2017, 1:50 PM.
Tags
None
Referenced Files
F151016580: D11864.id31594.diff
Sun, Apr 5, 11:41 AM
Unknown Object (File)
Sat, Apr 4, 6:07 AM
Unknown Object (File)
Wed, Apr 1, 1:27 AM
Unknown Object (File)
Mar 2 2026, 9:51 PM
Unknown Object (File)
Mar 2 2026, 3:43 PM
Unknown Object (File)
Feb 8 2026, 12:36 PM
Unknown Object (File)
Feb 8 2026, 12:10 PM
Unknown Object (File)
Feb 8 2026, 7:11 AM
Subscribers

Details

Summary

This issue caused the assertion at the line 498 to be triggered:

	bucket = (cc[0] - map->ppm_lowpc) / FUNCTION_ALIGNMENT;
	assert(bucket < pgf->pgf_nbuckets);

when cc value appears at the top of the image.

I triggered it with the pmcstat -R log -g.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 4 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.