Page MenuHomeFreeBSD

Mk/Uses/shebangfix.mk: Fix SHEBANG_FILES to use find(1)
ClosedPublic

Authored by feld on Aug 3 2017, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 12:10 AM
Unknown Object (File)
Fri, Jun 21, 12:06 AM
Unknown Object (File)
Wed, Jun 5, 7:00 AM
Unknown Object (File)
Apr 26 2024, 2:09 AM
Unknown Object (File)
Apr 25 2024, 8:06 PM
Unknown Object (File)
Apr 25 2024, 8:02 PM
Unknown Object (File)
Apr 24 2024, 8:06 PM
Unknown Object (File)
Jan 18 2024, 8:37 AM
Subscribers
None

Details

Summary

Ports like net/vmware-vsphere-cli use SHEBANG_FILES with globs like so:

SHEBANG_FILES= bin/* ...

As of FreeBSD 11.??? sed has changed and errors if attempted on non-file objects. In
the case of the cited port there are many other files in the bin/
directory which are symlinks for compatibility with old scripts. This
causes the port patching to fail.

Changing the SHEBANG_FILES logic to use find(1) like SHEBANG_REGEX and
SHEBANG_GLOB seems to be a sane solution with no negative impact.

Test Plan

exp-run?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks like a good idea. An exp-run may be needed though, there are strange things happening in SHEBANG_FILES.

This revision was automatically updated to reflect the committed changes.