Add DOCS option to dns/libidn2

[tz]

Summary

New version of dns/libidn2 drags in ruby and an rubygem as build-depends. Even if no docs are wanted.
Patch adds DOCS option to allow disabling the DOCS and avoiding the new build-dependencies.

Attention:
While doing the QA i noticed one glitch. When build without doc there is a warning in stage "compress-manpage". But i have no idea how to fix.

Test Plan

Build tests for 10.3 and 11.0 amd, i386

[mat]

Note that man pages must not be dependent on the DOCS option, if you must make them optional, use a MANPAGES option.

Makefile

25

Unless --enable-doc does not exist, this should be:

DOCS_CONFIGURE_ENABLE= doc

[tz]

In D11823#245147, @mat wrote:

Note that man pages must not be dependent on the DOCS option, if you must make them optional, use a MANPAGES option.

Thanks for the review! I switched from DOCS to MANPAGES and changed %%PORTDOCS%% in pkg-plist to %%MANPAGES%%. But this wont work. What do i need to set in pkg-plist?
I did first look at devel/valgrind-devel and devel/tig for inspiration. The first one uses %%MANPAGES%% but i can't see why it works for him. Any advice @mat ?

[mat]

In D11823#245165, @tz wrote:

Thanks for the review! I switched from DOCS to MANPAGES and changed %%PORTDOCS%% in pkg-plist to %%MANPAGES%%. But this wont work. What do i need to set in pkg-plist?

MANPAGES seems to be the right one. Did you add OPTIONS_SUB=yes to the Makefile in your testing ?

[tz]

That did the trick, thanks! :) But what does this option do?

[mat]

In D11823#245167, @tz wrote:

That did the trick, thanks! :) But what does this option do?

So, you are a ports committer, and you have not read the porter's handbook ? 5.13. Makefile Options

[mat]

pkg-plist

27–39

These should be behind %%PORTDOCS%% not %%MANPAGES%%.

[sunpoet]

Thank mat@ and tz@.
I've found a better solution so this is not needed anymore.

[tz]

In D11823#245207, @mat wrote:

In D11823#245167, @tz wrote:

That did the trick, thanks! :) But what does this option do?

So, you are a ports committer, and you have not read the porter's handbook ? 5.13. Makefile Options

Sarcasm don't work very well via text. I did read the porters handbook - several times. But without practice its not possible to *remember* everything. And without any practical hint from the software its hard to even know were to look for. Therefore i really appreciate reviews very much.

[tz]

Overcome by events