Details
- Reviewers
wblock bcr - Commits
- rD50628: Rewrite the Makefile chapter a bit to promote DISTVERSION.
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
- Move a table, and add a pointer to DISTNAME.
- Fix the "Package Naming Examples" table. It was badly outdated.
- Replace usage of PORTVERSION with DISTVERSION.
A few comments
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 97 ↗ | (On Diff #31477) | The <varname> should be <option>, see |
| 110 ↗ | (On Diff #31477) | s/version./version, respectively./ |
| 133 ↗ | (On Diff #31477) | How about: "... as they have the same version."? |
| 144 ↗ | (On Diff #31477) | I would put the "think" part in () like this: P.S.: Now that I've read the other examples, I think this is fine without (), but add a comma before the "think" part. |
| 228 ↗ | (On Diff #31477) | s/end/ends/ |
| 242 ↗ | (On Diff #31477) | I'd break this up into two sentences. ... their versions. For example, ... |
| 249 ↗ | (On Diff #31477) | s/sometime/sometimes/ |
| 267 ↗ | (On Diff #31477) | Maybe use "constructing" or "building" instead of computing here? |
| 316 ↗ | (On Diff #31477) | when the software's versioning |
One more fix...
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 316 ↗ | (On Diff #31479) | Now you still have to add the "the" after "when". I marked it up differently, so you may have not noticed it in the earlier comment. ;-) |
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 316 ↗ | (On Diff #31479) | You are right, I had not noticed it. 🤔 |