Subversion is not installed by textproc/docproj by default.

[deb_freebsdfoundation.org]

Summary

In ports running make-all-depends-list in textproc/docproj reveals subversion is not installed as part of the package.

[bcr]

It's true, the port does not install subversion when building it from ports, because we have svnlite in the base system that can do the same back tasks. The problem is, the primer is using svn commands (in that chapter at least) and would require a rewrite to use svnlite in all the examples shown. The question is whether we want to do that or just add subversion back into the port. Adding doceng@ for discussion.

[gjb]

Two problems:

1. If we replace 'svn' with 'svnlite', we should probably do that throughout the tree (which, IMHO, is too much churn).

2. If we re-enable building devel/subversion, that is a user-visible change that overall provides no benefit.

I think we should just add a note to the effect of something like "if /usr/bin/svnlite exists, that can be used to replace 'svn' commands throughout this document."

[bcr]

That's a good idea, Glen.
Deb, can you add the text Glen suggested, create and upload another diff? I can help you if you want or can do the change myself, just let me know.

[sevan]

In D11807#245200, @gjb wrote:

Two problems:

1. If we replace 'svn' with 'svnlite', we should probably do that throughout the tree (which, IMHO, is too much churn).

2. If we re-enable building devel/subversion, that is a user-visible change that overall provides no benefit.

I think we should just add a note to the effect of something like "if /usr/bin/svnlite exists, that can be used to replace 'svn' commands throughout this document."

This is a separate issue but the php-arcanist package by default tries to use the svn command (didn't get to the point of looking at trying to reconfigure arcanist to use svnlite (is it even possible?))

Our workflow went as follows:

1. following the FDP, installed the docproj package
2. tried to use svn command snippet to clone docs repo
3. realised svn isn't installed & used svnlite
4. edited paragraph in this review
5. installed php-arcanist
6. attempted to submit diff to review only to realise arc tries to execute svn by default.

At this point we didn't dig further into re-configuring arc but just installed the subversion package.

[deb_freebsdfoundation.org]

Provide example on how to install Subversion.

[bcr]

Two minor style nits.
You also need to modify the Quickstart section 1.1, item 1 to instruct users to install the subversion port as well.

en_US.ISO8859-1/books/fdp-primer/working-copy/chapter.xml

44 ↗

(On Diff #31586)

Only a minor nit: we use two spaces after a sentence stop.

46 ↗

(On Diff #31586)

You need to indent this to be on the same level as the tag below (the <sect1>).

[sevan]

Address points raised.

[sevan]

Zap trailing whitespace

[bcr]

Can you put the changes to the Quickstart section 1.1, item 1, adding Subversion up as well?

[sevan]

Direct reader to install packages in the quickstart section as well.

[bcr]

Two more things...

en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml

84 ↗

(On Diff #32222)

There is a sentence stop missing here. I guess you have to break the long <application> tag before the "and" into the next line.

88 ↗

(On Diff #32222)

There is a closing </para> tag missing here at the end.

[sevan]

Address points.

[sevan]

Once more.

[bcr]

Looks good now, thanks for working on it!