bhyve/vga.c: fix atc_color_select_67 bit shift
ClosedPublic
Actions

Authored by rlibby on Jul 28 2017, 6:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 21, 6:07 PM

	Unknown Object (File)
	Sat, Jun 20, 6:15 PM

	Unknown Object (File)
	Sat, Jun 20, 1:33 AM

	Unknown Object (File)
	Thu, Jun 18, 7:47 AM

	Unknown Object (File)
	Sun, Jun 14, 5:35 PM

	Unknown Object (File)
	Jun 4 2026, 7:55 PM

	Unknown Object (File)
	Jun 4 2026, 5:25 PM

	Unknown Object (File)
	Jun 3 2026, 5:14 PM

View All Files

Subscribers

markj

Details

Reviewers

grehan
tychon

Commits

rS321669: bhyve/vga.c: fix atc_color_select_67 bit shift

Summary

Gcc noticed that the result of the bit shift is always zero. Shift so
that the ATC_CS_C67 bits end up in bits 6 & 7.

Test Plan

gcc

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jul 28 2017, 6:03 PM

Harbormaster completed remote builds in B10733: Diff 31316.Jul 28 2017, 6:04 PM

tychon accepted this revision.Jul 28 2017, 6:22 PM

This revision is now accepted and ready to land.Jul 28 2017, 6:22 PM

grehan accepted this revision.Jul 28 2017, 6:25 PM

Approved

Closed by commit rS321669: bhyve/vga.c: fix atc_color_select_67 bit shift (authored by rlibby). · Explain WhyJul 28 2017, 9:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

vga.c

2 lines

Diff 31326

View Options

bhyve/vga.c: fix atc_color_select_67 bit shiftClosedPublicActions