Page MenuHomeFreeBSD

net-mgmt/netdata: Fix build on 12.0-CURRENT r320783
AbandonedPublic

Authored by tobik on Jul 19 2017, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 9:26 AM
Unknown Object (File)
Dec 31 2023, 11:47 PM
Unknown Object (File)
Sep 23 2023, 11:04 AM
Unknown Object (File)
Aug 22 2023, 6:04 PM
Unknown Object (File)
Aug 15 2023, 1:18 PM
Unknown Object (File)
Apr 7 2023, 4:05 PM
Unknown Object (File)
Mar 21 2023, 11:33 AM
Subscribers

Details

Reviewers
mmokhi
Summary

I'm running 12.0-CURRENT r320873 and building net-mgmt/netdata
fails with:

apps_plugin.c:1575:101: error: no member named 'kf_sa_local' in 'struct kinfo_file'
                            sprintf(fdsname, "socket: other: %d %s %s", fds->kf_sock_protocol, fds->kf_sa_local.__ss_pad1, fds->kf_sa_local.__ss_pad2);
                                                                                               ~~~  ^
...
freebsd_sysctl.c:753:20: error: variable has incomplete type 'struct vmmeter'
    struct vmmeter vmmeter_data;
                   ^
...

AFAICT we need to explicitly ask for struct vmmeter by defining
_WANT_VMMETER now, and struct kinfo_file was updated with the
ino64 commits and kf_sa_local was moved to
kf_un.kf_sock.kf_sa_local.

Test Plan

poudriere testport 11.0/amd64, 10.3/i386, 12.0/amd64 ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10566
Build 10973: arc lint + arc unit

Event Timeline

I think it was parallel work in same time ``:-] ๐Ÿ˜…
Already fixed on --> https://reviews.freebsd.org/D11648

Thanks a lot BTW ๐Ÿ™

I think it was parallel work in same time ``:-] ๐Ÿ˜…
Already fixed on --> https://reviews.freebsd.org/D11648

Thanks a lot BTW ๐Ÿ™

Woops! Thanks for fixing :)