Details

Reviewers

emaste
gjb

Commits

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

usr.sbin/bsdinstall/scripts/checksum
35 ↗	(On Diff #30923)	This committed as part of rS321178
66 ↗	(On Diff #30923)	usual sh style puts the individual case entries aligned with `case`
68 ↗	(On Diff #30923)	Maybe add "Please check for a newer snapshot." -- @gjb does that sound reasonable?

usr.sbin/bsdinstall/scripts/checksum
66 ↗	(On Diff #30923)	My vim auto-indent script does the same indentation style as in this diff, which I tend to prefer. We do not have a hard-written style(9) for sh(1) scripts that I can find.
68 ↗	(On Diff #30923)	Yes.

usr.sbin/bsdinstall/scripts/checksum
66 ↗	(On Diff #30923)	But this indentation style is not consistent with the rest of bsdinstall

usr.sbin/bsdinstall/scripts/checksum
66 ↗	(On Diff #30923)	If for consistency in bsdinstall(8), then ok.

usr.sbin/bsdinstall/scripts/checksum
66 ↗	(On Diff #30923)	fwiw the no-extra-indent style is nearly universal in the src tree (in bin/usr.bin/sbin/usr.sbin)

Updated based on review

ygy marked 8 inline comments as done.Jul 19 2017, 3:42 AM

Pulled from upstream to reflect whitespace fix from another commit

usr.sbin/bsdinstall/scripts/checksum
65–66 ↗	(On Diff #30952)	One small improvement, we should be able to avoid the extra invocation (sed) and just use `-ALPHA\|-CURRENT\|-STABLE\|*-PRERELEASE)` in the case statement.

This revision was automatically updated to reflect the committed changes.