Page MenuHomeFreeBSD

math/R: set SONAME for some R libraries
ClosedPublic

Authored by jrm on Jul 17 2017, 1:17 AM.

Details

Summary

These are some suggested tweaks to the patch for math/R submitted by pawel@
in Bug 219776.

  • Add links in ${PREFIX}/lib for the libraries that we are using as system libraries.
  • Set LIBVER to ${PORTVERSION:R}, i.e., R's major_version.minor_version

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrm created this revision.Jul 17 2017, 1:17 AM
jrm updated this revision to Diff 30850.Jul 17 2017, 1:58 AM

Minor tweak to how the links in ${PREFIX}/lib are created.

pawel added a subscriber: pawel.Jul 17 2017, 8:02 AM
mat added inline comments.Jul 17 2017, 1:27 PM
math/R/Makefile
149–159 ↗(On Diff #30850)

I wonder if this should not be replaced by

USE_LDCONFIG= ${PREFIX}/lib/R/lib
jrm added inline comments.Jul 17 2017, 1:37 PM
math/R/Makefile
149–159 ↗(On Diff #30850)

Upstream makes a big deal about the libraries under lib/R/lib/ not being system libraries. If you are interested in the gory details, this thread spells it out: https://stat.ethz.ch/pipermail/r-devel/2016-November/073397.html. I thought creating links under lib/ would make it clear that we are intending to make these system libraries.

jrm added a reviewer: pawel.Jul 17 2017, 1:38 PM
mat added inline comments.Jul 17 2017, 1:59 PM
math/R/Makefile
149–159 ↗(On Diff #30850)

Mmmmm, but does any port actually needs this ?

pawel added inline comments.Jul 17 2017, 3:56 PM
math/R/Makefile
149–159 ↗(On Diff #30850)

I find this additional links messy and fail to see benefits. Interested consumers can get correct linker flags from pkg-config:

% pkg-config --libs libR
-Wl,--export-dynamic -L/usr/local/lib -Wl,-rpath=/usr/local/lib/gcc5 -L/usr/local/lib/gcc5 -B/usr/local/bin -fstack-protector -L/usr/local/lib/R/lib -lR

So my vote here goes for USE_LDCONFIG= ${PREFIX}/lib/R/lib like in my initial patch.

jrm updated this revision to Diff 30886.Jul 17 2017, 7:16 PM

Do not create links to lib/R/lib/* in lib/.

This revision was automatically updated to reflect the committed changes.