net/glusterfs port update to latest 3.11.1 release

[craig001_lerwick.hopto.org]

Summary

update the port to the latest and greatest.

changes to Makefile, patches, and pkg-plist

Test Plan

I intend to;

• portlint,
• poudriere

then call for testing.

[craig001_lerwick.hopto.org]

used make makepatch to correctly recreate the files/patches after first applying patch -b -p0 to a vanilla make extract.

[craig001_lerwick.hopto.org]

root@condor:/usr/ports/net/glusterfs # portlint -C
WARN: Makefile: [5]: whitespace before end of line.
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Makefile: possible use of absolute pathname "/boot/modules".
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 4 warnings found.

[craig001_lerwick.hopto.org]

diff's broke in stage-qa:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/glusterfind'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/gfind_missing_files/gfid_to_path.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/glusterfind/changelog.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/glusterfind/nodeagent.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/glusterfind/brickfind.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/events/glustereventsd.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/peer_eventsapi.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'sbin/gcron.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'sbin/snap_scheduler.py'
Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'share/glusterfs/scripts/post-upgrade-script-for-quota.sh'
Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'share/glusterfs/scripts/pre-upgrade-script-for-quota.sh'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'share/glusterfs/scripts/eventsdash.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/events/glustereventsd.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/peer_eventsapi.py'
Warning: Bad symlink '/usr/local/sbin/glustereventsd' pointing to an absolute pathname '/usr/local/libexec/glusterfs/events/glustereventsd.py'
Warning: Bad symlink '/usr/local/sbin/gfind_missing_files' pointing to an absolute pathname '/usr/local/libexec/glusterfs/gfind_missing_files/gfind_missing_files.sh'
Warning: Bad symlink '/usr/local/sbin/gluster-eventsapi' pointing to an absolute pathname '/usr/local/libexec/glusterfs/peer_eventsapi.py'
Warning: Bad symlink '/var/db/glusterd/hooks/1/delete/post/S57glusterfind-delete-post' pointing to an absolute pathname '/usr/local/libexec/glusterfs/glusterfind/S57glusterfind-delete-post.py'
*** Error code 1

[craig001_lerwick.hopto.org]

make makepatch renamed some of the patches (underscore instead of hyphen)
diff now captures that change

[mat]

Could you upload the diff with arcanist arc diff --update D11550 ? Or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

[craig001_lerwick.hopto.org]

new diff as per Mat's request (using the svn diff -x -U9999)

[craig001_lerwick.hopto.org]

oh no... doesn't look like it's building on 11.0-RELEASE clang.
It does build on 11.1 RC2 (that also has the required fuse changes)

maybe a conditional required ??

[craig001_lerwick.hopto.org]

conditional added to fix build issue on 11.0-RELEASE (clang fails)

[mat]

Makefile

17–21

Put all this at the end.

20

You probably mean USE_GCC=yes here.

[craig001_lerwick.hopto.org]

changes made as suggested by Mat with thanks....

[craig001_lerwick.hopto.org]

osversion conditional moved up a touch

[mat]

Looks ok, feel free to submit a PR to get this committed.

Makefile

43

add empty line before.

[craig001_lerwick.hopto.org]

empty line added as suggested

[craig001_lerwick.hopto.org]

thanks Mat... new PR created;
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220674

[craig001_lerwick.hopto.org]

updated patch from Danilo, sync with PR