Add nsecs_to_jiffies64() and jiffies_to_{nsecs,usecs}().

[markj]

Summary

Fix style in related functions.

[• hselasky]

sys/compat/linuxkpi/common/include/linux/jiffies.h

100 ↗

(On Diff #30586)

These max checks are not sufficient for very large input values. You should also verify that the multiplication does not exceed 64-bits!

const uint64_t nsec_max = -1ULL / (uint64_t)hz;
if (nsec > nsec_max)
nsec = nsec_max;

114 ↗

(On Diff #30586)

passed jiffies argument should be "int" to avoid problems!

[markj]

• Address review comments.

[• hselasky]

sys/compat/linuxkpi/common/include/linux/jiffies.h

99 ↗

(On Diff #30612)

Can you add this check to the msecs_to_jiffies and usecs_to_jiffies aswell?

[• hselasky]

sys/compat/linuxkpi/common/include/linux/jiffies.h

114 ↗

(On Diff #30586)

Do you need to cast j to (uint64_t) ??

[markj]

Address review comments.

[• hselasky]

sys/compat/linuxkpi/common/include/linux/jiffies.h

126 ↗

(On Diff #30656)

(uint64_t)(unsigned int)j ???

We don't like negative times??

Same below. Else the patch looks OK.

[markj]

sys/compat/linuxkpi/common/include/linux/jiffies.h

126 ↗

(On Diff #30656)

Sorry, that was stupid. :(

Thanks for the review.

99 ↗

(On Diff #30612)

Done.