Page MenuHomeFreeBSD

databases/mongodb34: update to 3.4.5
ClosedPublic

Authored by ultima on Jul 6 2017, 1:04 AM.

Details

Summary
  • Updated to 3.4.5
  • Sorted Makefile
  • regenerated patches

PR\: 220393
Sumitted by\: Eric Camachat <eric@camachat.org> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
WARN: Makefile: "TEST_DEPENDS" has to appear earlier.
0 fatal errors and 3 warnings found.

poudriere:
103i386: is only for amd64, while you are running i386 (reason: "Only supported on amd64 (i386 deprecated in v3)")
103amd64
110i386: is only for amd64, while you are running i386 (reason: "Only supported on amd64 (i386 deprecated in v3)")
110amd64
12i386: is only for amd64, while you are running i386 (reason: "Only supported on amd64 (i386 deprecated in v3)")
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ultima created this revision.Jul 6 2017, 1:04 AM
lifanov edited edge metadata.Jul 6 2017, 1:37 AM

As portlint is complaining, move LIB_DEPENDS and TEST_DEPENDS up

databases/mongodb34/files/patch-src_mongo_db_fts_unicode_string.cpp
1 ↗(On Diff #30463)

Looks like the date is the only thing that changed here.
Don't commit this one file.

ultima updated this revision to Diff 30469.Jul 6 2017, 1:52 AM
  • Removed databases/mongodb34/files/patch-src_mongo_db_fts_unicode_string.cpp from diff
ultima updated this revision to Diff 30470.Jul 6 2017, 1:53 AM

Removed databases/mongodb34/files/patch-rpm_mongod.conf from diff, only date/time change

ultima added a comment.Jul 6 2017, 2:15 AM

As portlint is complaining, move LIB_DEPENDS and TEST_DEPENDS up

ah, yeah this actually a false positive according to 13.1.5 [1]. It comes before *_DEPENDS. Should I change it back and follow portlint over handbook?

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order

lifanov accepted this revision.Jul 6 2017, 3:28 PM

Handbook trumps portlint.

This revision is now accepted and ready to land.Jul 6 2017, 3:28 PM
This revision was automatically updated to reflect the committed changes.