Page MenuHomeFreeBSD

www/py-django-post_office: Updated to 3.0.0
ClosedPublic

Authored by ultima on Jul 5 2017, 6:01 PM.

Details

Summary
  • Updated to 3.0.0

Changelog: https://github.com/ui/django-post_office (At the bottom)

Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Jul 6 2017, 1:32 AM
This revision was automatically updated to reflect the committed changes.
head/www/py-django-post_office/Makefile
25

Remove this and change PORTVERSION to 3.0.

As a general rule, when using USE_GITHUB, and unless using a commit hash, you almost never use GH_TAGNAME.

head/www/py-django-post_office/Makefile
25

K, I changed it because I was worried that the new versioning wouldn't be considered higher with the missing .0. Safer to keep it the same. Will remove tagname.

head/www/py-django-post_office/Makefile
25

If you are not sure what happens with versions, ask pkg:

$ pkg version -t 3.0.0 3.0
=
head/www/py-django-post_office/Makefile
25

oh, wow that is quite useful!

Should this be fixed with another commit or just wait for the next update/revision? Danfe mentioned I should avoid gratuitous changes. This maybe considered one.

Fixing an error is not a gratuitous change. Besides, you've been asked to do it by mat.

You have my approval to delete the GH_TAGNAME line -- no need to reopen this review, you can just commit the
fix. Remember add 'Reported by: mat'

Fixing an error is not a gratuitous change. Besides, you've been asked to do it by mat.

You have my approval to delete the GH_TAGNAME line -- no need to reopen this review, you can just commit the
fix. Remember add 'Reported by: mat'

K thanks! and thank you mat for continuously reviewing my commits.