Page MenuHomeFreeBSD

Create default dirs and symlink to dnsapi scripts
ClosedPublic

Authored by dvl on Jul 2 2017, 4:19 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10281
Build 10699: arc lint + arc unit

Event Timeline

dvl created this revision.Jul 2 2017, 4:19 PM
dvl updated this revision to Diff 30324.Jul 2 2017, 4:29 PM

Remove wrong code from files/pkg-install.in

mat added inline comments.Jul 3 2017, 1:00 PM
security/acme.sh/Makefile
45

You cannot put sample files in there. You have to move them somewhere else, like EXAMPLESDIR.

newsyslog.conf has:

<include> /usr/local/etc/newsyslog.conf.d/*

So all the files in there are always used. If you put a .sample file, it will be used.

Also, the file should probably be named acme.sh, and not the very long name you have now.

security/acme.sh/files/pkg-install.in
10–12
/usr/bin/install -d -o acme -g acme -m 750 ~/acme/.acme.sh
16–18

/usr/bin/install -d -o acme -g acme -m 750 ~/acme/certs

22

I would use %%EXAMPLESDIR%% directly here, no real need to create a variable.

dvl updated this revision to Diff 30376.Jul 3 2017, 9:41 PM

Updates as suggested

This revision was automatically updated to reflect the committed changes.
dvl marked 4 inline comments as done.