www/ufdbguard: update to 1.33.3

[ultima]

Summary

• Updated to 1.33.3
• Changed UNIXSOCKETS default off

Changelog: https://www.urlfilterdb.com/products/releases.html

PR\: 220286
Sumitted by\: <[e-mail]> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: possible use of absolute pathname "/var/run/${PORTNAME}".
WARN: Makefile: possible use of absolute pathname "/var/db/${PORTNAME}".
WARN: Makefile: possible use of absolute pathname "/var/log/${PORTNAME}".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 4 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[ultima]

I was looking at the port and noticed there are some things that need to be fixed. I will get this revised before commit.

www/ufdbguard/Makefile

57 ↗

(On Diff #30186)

Not required.

70 ↗

(On Diff #30186)

Could be changed to the more modern OPT_BROKEN

74 ↗

(On Diff #30186)

Could be changed to the more modern OPT_BROKEN

[ultima]

Ah nevermind on the SSL_DEFAULT, I had thought that was an option.

[ultima]

Added comment about MAKE_JOBS_UNSAFE= yes

[mat]

www/ufdbguard/Makefile

64–65 ↗

(On Diff #30188)

​UNIXSOCKETS_CONFIGURE_WITH=unix-sockets

Side note, is there any reason not to have it always on (as in, not an option).

71–77 ↗

(On Diff #30188)

BROKEN_SSL=openssl-devel libressl-devel

and remove b.p.pre.mk before.

[ultima]

www/ufdbguard/Makefile

64–65 ↗

(On Diff #30188)

The same question had crossed my mind. I'll add it to query.

71–77 ↗

(On Diff #30188)

Thanks, I had thought there was a better method. I just looked in the wong place.

[ultima]

Did not fully understand the reply, but seems confident
this is the correct path.

It's decided at compile time if it works via unix-socket
or tcp socket. There is no such config option at runtime.
I know, this is weird. Also I turned off unix-socket by
default as tcp socket way has more use cases.
<[e-mail]> (maintainer)

[ultima]

Added missing to option _WITH

[matthew]

Getting size mismatches:

=======================<phase: fetch          >============================
===>  License GPLv2 accepted by the user
===>   ufdbGuard-1.33.3 depends on file: /usr/local/sbin/pkg - found
=> ufdbGuard-1.33.3.tar.gz doesn't seem to exist in /portdistfiles/.
=> Attempting to fetch https://downloads.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz
fetch: https://downloads.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz: size mismatch: expected 2488914, actual 41919
=> Attempting to fetch https://cytranet.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz
fetch: https://cytranet.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz: size mismatch: expected 2488914, actual 26674
=> Attempting to fetch https://dronedata.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz
fetch: https://dronedata.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz: No address record
=> Attempting to fetch https://excellmedia.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz
fetch: https://excellmedia.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz: size mismatch: expected 2488914, actual 41919
=> Attempting to fetch https://freefr.dl.sourceforge.net/project/ufdbGuard/1.33/ufdbGuard-1.33.3.tar.gz

Looks like it's pulling down some sort of HTML page instead of the actual distfile. Looks like SourceForge are playing silly buggers.

[matthew]

www/ufdbguard/Makefile

7 ↗

(On Diff #30271)

Ah -- I see what the problem is. You need this:

MASTER_SITES=   SF/${PORTNAME:tl}/1.33

[matthew]

Looks like it needs to be marked broken with libressl:

cc -I.. -I. -I. -O2 -pipe  -fstack-protector -fno-strict-aliasing -I/usr/local/include -c ufdbchkport.c
ufdbchkport.c:1233:42: warning: comparison of array 'UFDBglobalCAcertsDir' equal to a null pointer is always false [-Wtautological-pointer-compare]
                         UFDBglobalCAcertsFile, UFDBglobalCAcertsDir==NULL ? "none" : UFDBglobalCAcertsDir );
                                                ^~~~~~~~~~~~~~~~~~~~  ~~~~
ufdbchkport.c:2334:20: error: no member named 'state' in 'struct ssl_st'
   state = (*ssl)->state;
           ~~~~~~  ^
1 warning and 1 error generated.
*** Error code 1

Stop.
make[2]: stopped in /wrkdirs/usr/ports/www/ufdbguard/work/ufdbGuard-1.33.3/src
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/www/ufdbguard/work/ufdbGuard-1.33.3
*** Error code 1

[ultima]

In D11397#236540, @matthew wrote:

Looks like it needs to be marked broken with libressl:

cc -I.. -I. -I. -O2 -pipe  -fstack-protector -fno-strict-aliasing -I/usr/local/include -c ufdbchkport.c
ufdbchkport.c:1233:42: warning: comparison of array 'UFDBglobalCAcertsDir' equal to a null pointer is always false [-Wtautological-pointer-compare]
                         UFDBglobalCAcertsFile, UFDBglobalCAcertsDir==NULL ? "none" : UFDBglobalCAcertsDir );
                                                ^~~~~~~~~~~~~~~~~~~~  ~~~~
ufdbchkport.c:2334:20: error: no member named 'state' in 'struct ssl_st'
   state = (*ssl)->state;
           ~~~~~~  ^
1 warning and 1 error generated.
*** Error code 1

Stop.
make[2]: stopped in /wrkdirs/usr/ports/www/ufdbguard/work/ufdbGuard-1.33.3/src
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/www/ufdbguard/work/ufdbGuard-1.33.3
*** Error code 1

Nice catch, I'm still trying to figure out the correct way for testing openssl forks. I guess using sets with different variant would be the best choice. This isn't implemented in my testing env yet but it is on the todo list.

www/ufdbguard/Makefile

7 ↗

(On Diff #30271)

Yeah I was having issues downloading as well, it usually takes about 5-10 attempts for it to download the correct file....

Mind explaining what :tl does?

[ultima]

• Added :tl
• Added libressl to broken

[matthew]

www/ufdbguard/Makefile

7 ↗

(On Diff #30271)

${FOO:tl} just gives you ${FOO} mapped to lower case. See make(1)

[matthew]