Page MenuHomeFreeBSD

security/zeronet: Update to 0.5.6
ClosedPublic

Authored by ultima on Jun 25 2017, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 3:03 AM
Unknown Object (File)
Fri, Nov 1, 9:41 PM
Unknown Object (File)
Mon, Oct 28, 8:30 AM
Unknown Object (File)
Oct 23 2024, 8:20 AM
Unknown Object (File)
Oct 5 2024, 10:56 AM
Unknown Object (File)
Sep 5 2024, 1:27 AM
Unknown Object (File)
Aug 21 2024, 12:05 PM
Unknown Object (File)
Aug 20 2024, 7:30 PM
Subscribers

Details

Summary
  • Updated to 0.5.6

Changelog: https://github.com/HelloZeroNet/ZeroNet/releases/tag/v0.5.6

PR\: 220123
Sumitted by\: Yuri Victorovich <yuri@rawbw.com> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: possible use of absolute pathname "/var/db/zeronet".
WARN: Makefile: possible use of absolute pathname "/var/log/zeronet".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 3 warnings found.
They are absolute pathnames, but I think they are fine.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

These are legitimate symbolic links.
Please disregard the warnings. -Yuri Victorovich
Also opened a bug report, about them. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220263

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Apart from the couple of absolute symlinks that the maintainer mentions, this looks fine:

====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/share/zeronet/log' pointing to an absolute pathname '/var/log/zeronet'
Warning: Bad symlink '/usr/local/share/zeronet/data' pointing to an absolute pathname '/var/db/zeronet'

However converting those to a relative path ../../../../var/log/zeronet seems a bit ... pedantic.

Apart from that,

lgtm

This revision is now accepted and ready to land.Jun 25 2017, 9:12 PM

The "/var/db" should be excluded from this test. Maybe instead we should test if a port puts anything in LOCALBASE/var (as, say, prosody does) and error on that.

This revision was automatically updated to reflect the committed changes.