Page MenuHomeFreeBSD
Differential D11354

ext2fs: add support for e2di_uid_high and e2di_gid_high.
ClosedPublic
Actions

Authored by pfg on Jun 25 2017, 4:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 1:11 AM
Unknown Object (File)
Jan 27 2024, 4:21 AM
Unknown Object (File)
Dec 20 2023, 5:15 AM
Unknown Object (File)
Dec 5 2023, 6:45 PM
Unknown Object (File)
Nov 24 2023, 9:17 AM
Unknown Object (File)
Nov 11 2023, 4:07 AM
Unknown Object (File)
Nov 10 2023, 5:06 AM
Unknown Object (File)
Oct 10 2023, 3:10 AM
View All 22 Files
Subscribers
imp

Details

Reviewers
fsu
Commits
rS320408: ext2fs: Support e2di_uid_high and e2di_gid_high.
Summary

It is unclear to me exactly when they were introudced: it appears the are
part of ext3 but only officially available when a bigger inode is
supported ... basically when the extended timestamps are there.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pfg created this revision.Jun 25 2017, 4:11 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 25 2017, 4:11 PM
Harbormaster completed remote builds in B10119: Diff 30058.Jun 25 2017, 4:11 PM
pfg updated this revision to Diff 30066.Jun 25 2017, 5:40 PM

Fix the shifts.
Move the extended inode changes to one unique if block.
Support both RW on ext3.

pfg updated this revision to Diff 30068.Jun 25 2017, 5:53 PM

Update (again) the shifts: e2di_uid and e2di_gid are just uint16_t.

Harbormaster completed remote builds in B10123: Diff 30068.Jun 25 2017, 5:53 PM
pfg updated this revision to Diff 30069.Jun 25 2017, 6:01 PM

more bit mangling.

Harbormaster completed remote builds in B10124: Diff 30069.Jun 25 2017, 6:01 PM
fsu edited edge metadata.Jun 26 2017, 6:57 AM

As, I learned linux sources you can use uid/gid high without E2DI_HAS_XTIME(ip) check, because it depends only from mount option on linux side, not from inode size.
So, seems like

ip->i_uid |= (uint32_t)ei->e2di_uid_high << 16;
ip->i_gid |= (uint32_t)ei->e2di_gid_high << 16;

could be moved out from if (E2DI_HAS_XTIME(ip)).

pfg updated this revision to Diff 30093.Jun 26 2017, 3:02 PM

Applying feedback from Fedor.

fsu accepted this revision.Jun 27 2017, 6:08 AM
This revision is now accepted and ready to land.Jun 27 2017, 6:08 AM
Closed by commit rS320408: ext2fs: Support e2di_uid_high and e2di_gid_high. (authored by pfg). · Explain WhyJun 27 2017, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
ext2fs/
8 lines

Diff 30134

View Options

head/sys/fs/ext2fs/ext2_inode_cnv.c

Loading...