[NEW PORT] mail/p5-Net-LMTP: Local Mail Transfer Protocol Client

[loader]

Summary

Proposed commit log message:

[NEW PORT] mail/p5-Net-LMTP: Local Mail Transfer Protocol Client

This module implements a client interface to the LMTP protocol,
enabling a perl5 application to talk to LMTP servers.

WWW: http://search.cpan.org/dist/Net-LMTP/

Reviewed_by: koobs
Approved by: koobs (ports)
Differential_Revision: D11320

Test Plan

• portlint: OK (looks fine.)
• testport: OK (poudriere: 1200030, armv6, '', perl5.24 tested)

[koobs]

LGTM, but consider using PLIST_FILES given there are only two entries (I'm surprised portlint didn't mention it?)

Perhaps worth waiting for @mat to review for perl specific

[loader]

In D11320#234608, @koobs wrote:

LGTM, but consider using PLIST_FILES given there are only two entries (I'm surprised portlint didn't mention it?)

Perhaps worth waiting for @mat to review for perl specific

Thanks @koobs, I had no idea about that. Just checked /usr/local/bin/polint,
it looks like when pkg-plist contains a line with % or @,
then we won't get this warning even it has less than 6 items.

537  sub checkplist {
... ...
637                  $seen_special++ if /[\%\@]/;                                          
... ...
883          if (!$seen_special && $item_count < $numpitems) {                             
884                  &perror("WARN", $file, -1, "There are only $item_count items in the plist Consider using PLIST_FILES instead of pkg-plist when installing less than $numpitems items.");                                                                                          
885          }

[koobs]

In D11320#234644, @loader wrote:

In D11320#234608, @koobs wrote:

LGTM, but consider using PLIST_FILES given there are only two entries (I'm surprised portlint didn't mention it?)

Thanks @koobs, I had no idea about that. Just checked /usr/local/bin/polint,
it looks like when pkg-plist contains a line with % or @,
then we won't get this warning even it has less than 6 items.

537  sub checkplist {
... ...
637                  $seen_special++ if /[\%\@]/;                                          
... ...
883          if (!$seen_special && $item_count < $numpitems) {                             
884                  &perror("WARN", $file, -1, "There are only $item_count items in the plist Consider using PLIST_FILES instead of pkg-plist when installing less than $numpitems items.");                                                                                          
885          }

Interesting, perhaps it was intended to only be used for unconditional entries, or perhaps there's a guideline, policy or historical recommendation not to use conditional (%) (or @) prefixed entries in PLIST_FILES.

Either way there's some clarification/improvement to be had, either in rule parsing, splitting of rules or messaging.

@marcus undoubtedly knows a lot more and can likely shed some light :)

Either way the changeset is approved (it passes QA).

[mat]

I think it may be so that people don't add PLIST_FILES entries with %%FOO%% in them.