science/metaf2xml: Update to 2.2

[ultima]

Summary

• Updated to 2.2

Changelog: http://metaf2xml.sourceforge.net/RelInfo-2.2.txt

PR\: 220081
Sumitted by\: <[e-mail]>
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: [33]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not be maintained by [e-mail].
0 fatal errors and 3 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[matthew]

science/metaf2xml/Makefile

45

This should be handled by USES=shebangfix for install.pl ?

[matthew]

There's a bunch of stuff pointed up by the QA tests:

====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-lang-es.xml' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-lang-es.xml'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-sum-ui.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-sum-ui.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-sum-html.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-sum-html.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-sum.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-sum.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-ui.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-ui.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-html.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-html.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-lang-de.xml' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-lang-de.xml'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-fullhtml.xsl' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-fullhtml.xsl'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-lang.xml' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-lang.xml'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-lang-ru.xml' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-lang-ru.xml'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/stations.xml' pointing to an absolute pathname '/usr/local/share/metaf2xml/stations.xml'
Warning: Bad symlink '/usr/local/www/metaf2xml/htdocs/metaf-lang-en.xml' pointing to an absolute pathname '/usr/local/share/metaf2xml/metaf-lang-en.xml'
Warning: Bad symlink '/usr/local/www/metaf2xml/cgi-bin/metaf.pl' pointing to an absolute pathname '/usr/local/bin/metaf.pl'
Warning: www/p5-CGI was in Perl CORE.  Check with `corelist CGI 0` and `corelist -a CGI` if it should be conditionally added depending on PERL_LEVEL
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.

Symlinks should preferably use a relative pathname. The warning about p5-CGI is a false alarm -- that *used* to be a perl core module, but it is no longer
so in any version of perl available from ports. Was dropped from perl core after perl-5.20.3.

[ultima]

Fix symlinks

[ultima]

Also updated poudriere logs

science/metaf2xml/Makefile

45

install.pl runs correctly with shebangfix, however in the script, another call to /usr/bin/perl to start a different script. This added post-patch will ensure all other /usr/bin/perl calls are correctly made. I did a grep -r /usr/bin/perl $WRKSRC after the shebangfix was applied and the above files were the ones that still had this set.

After make patch with install.pl added to shebandfix, and post-patch target commented:
grep -r /usr/bin/perl work/metaf2xml-2.2
work/metaf2xml-2.2/install.1:.IP "\s-1PERL \s0(default: \fI/usr/bin/perl\fR)" 4
work/metaf2xml-2.2/install.1:.IX Item "PERL (default: /usr/bin/perl)"
work/metaf2xml-2.2/INSTALL: PERL (default: /usr/bin/perl)
work/metaf2xml-2.2/Makefile:PERL ?= /usr/bin/perl
work/metaf2xml-2.2/install.pl:=item PERL (default: F</usr/bin/perl>)
work/metaf2xml-2.2/install.pl:my $PERL = getconfvar 'PERL', '/usr/bin/perl';
work/metaf2xml-2.2/install.pl: s{^#!/usr/bin/perl$}{#!$PERL}o;
work/metaf2xml-2.2/install.pl: s{^#!/usr/bin/perl$}{#!$PERL}o;
work/metaf2xml-2.2/install.pl: s{^#!/usr/bin/perl$}{#!$PERL}o;

[matthew]

science/metaf2xml/Makefile

45

Ah, I see. So install.pl is essentially doing it's own version of shebangfix? Hmm... in which replacing the string /usr/bin/perl is entirely the wrong approach -- what you need is for the variable $PERL to resolve to the correct path, which should come from the configuration.

Also, you probably don't need to shebangfix yourself what the software already fixes for itself.

[ultima]

Yes this is definitely the correct route.

[matthew]