Page MenuHomeFreeBSD

Fix multiple Coverity warnings in tftpd(8)
ClosedPublic

Authored by asomers on Jun 20 2017, 11:13 PM.
Tags
None
Referenced Files
F172696456: D11287.id.diff
Sun, Sep 20, 7:49 AM
Unknown Object (File)
Fri, Sep 18, 2:43 PM
Unknown Object (File)
Tue, Sep 15, 5:08 AM
Unknown Object (File)
Tue, Sep 8, 5:35 PM
Unknown Object (File)
Thu, Aug 27, 4:19 AM
Unknown Object (File)
Sun, Aug 23, 3:36 PM
Unknown Object (File)
Aug 18 2026, 8:02 PM
Unknown Object (File)
Aug 18 2026, 12:37 PM
Subscribers

Details

Summary

Fix multiple Coverity warnings in tftpd(8)

  • Initialize uninitialized variable (CID 1006502)
  • Delete dead code (CID 1006796, 1006794, 1006793)
  • strcpy => strlcpy (CID 1006792, 1006791, 1006790)
  • Check function return values (CID 1009442, 1009441, 1009440)

CID: 1006502, 1006796, 1006794, 1006793, 1006792, 1006791, 1006790,
CID: 1009442, 1009441, 1009440

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Actually, it turns out that the "dead code" wasn't dead after all; it's used by some files in the usr.bin/tftp directory. I need to restore those functions and fix their warnings the hard way.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2018, 4:14 PM
This revision was automatically updated to reflect the committed changes.