Page MenuHomeFreeBSD

Fix multiple Coverity warnings in tftpd(8)
ClosedPublic

Authored by asomers on Jun 20 2017, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 12:25 PM
Unknown Object (File)
Sat, Apr 25, 2:35 AM
Unknown Object (File)
Tue, Apr 7, 9:29 PM
Unknown Object (File)
Sun, Apr 5, 3:19 AM
Unknown Object (File)
Sun, Mar 29, 11:26 PM
Unknown Object (File)
Mar 17 2026, 5:36 AM
Unknown Object (File)
Mar 16 2026, 11:48 AM
Unknown Object (File)
Mar 15 2026, 7:09 PM
Subscribers

Details

Summary

Fix multiple Coverity warnings in tftpd(8)

  • Initialize uninitialized variable (CID 1006502)
  • Delete dead code (CID 1006796, 1006794, 1006793)
  • strcpy => strlcpy (CID 1006792, 1006791, 1006790)
  • Check function return values (CID 1009442, 1009441, 1009440)

CID: 1006502, 1006796, 1006794, 1006793, 1006792, 1006791, 1006790,
CID: 1009442, 1009441, 1009440

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Actually, it turns out that the "dead code" wasn't dead after all; it's used by some files in the usr.bin/tftp directory. I need to restore those functions and fix their warnings the hard way.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2018, 4:14 PM
This revision was automatically updated to reflect the committed changes.