Page MenuHomeFreeBSD

Fix multiple Coverity warnings in tftpd(8)
ClosedPublic

Authored by asomers on Jun 20 2017, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 4:41 AM
Unknown Object (File)
Sat, Sep 13, 7:29 AM
Unknown Object (File)
Sep 11 2025, 1:49 PM
Unknown Object (File)
Sep 11 2025, 11:55 AM
Unknown Object (File)
Aug 8 2025, 3:15 AM
Unknown Object (File)
Jul 21 2025, 12:27 PM
Unknown Object (File)
Jul 7 2025, 7:54 AM
Unknown Object (File)
Jul 7 2025, 5:19 AM
Subscribers

Details

Summary

Fix multiple Coverity warnings in tftpd(8)

  • Initialize uninitialized variable (CID 1006502)
  • Delete dead code (CID 1006796, 1006794, 1006793)
  • strcpy => strlcpy (CID 1006792, 1006791, 1006790)
  • Check function return values (CID 1009442, 1009441, 1009440)

CID: 1006502, 1006796, 1006794, 1006793, 1006792, 1006791, 1006790,
CID: 1009442, 1009441, 1009440

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Actually, it turns out that the "dead code" wasn't dead after all; it's used by some files in the usr.bin/tftp directory. I need to restore those functions and fix their warnings the hard way.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2018, 4:14 PM
This revision was automatically updated to reflect the committed changes.