Page MenuHomeFreeBSD

Add ports for qtdiag and qtplugininfo from qt-tools.
ClosedPublic

Authored by tcberner on Jun 20 2017, 6:51 AM.

Details

Summary

Both can be helpful when debugging Qt stuff.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner created this revision.Jun 20 2017, 6:51 AM
mat added inline comments.Jun 21 2017, 7:29 AM
sysutils/qt5-qtdiag/Makefile
13 ↗(On Diff #29845)

USES should be first in that block. from here

22 ↗(On Diff #29845)

Add blank line before the target.

sysutils/qt5-qtdiag/pkg-descr
1 ↗(On Diff #29845)

Expand.

sysutils/qt5-qtplugininfo/Makefile
22 ↗(On Diff #29845)

blank line before.

sysutils/qt5-qtplugininfo/pkg-descr
1 ↗(On Diff #29845)

Expand.

rakuco added a subscriber: rakuco.Jun 21 2017, 7:35 AM
rakuco added inline comments.
Mk/bsd.qt.mk
178 ↗(On Diff #29845)

Can you land this part separately?

tcberner marked an inline comment as done.Jun 21 2017, 8:28 AM
tcberner updated this revision to Diff 29890.Jun 21 2017, 8:34 AM
  • Reorder USES
  • Rather than coming up with a good description, follow the rest of the Qt5 ports and use the one from devel/qt5
  • Add empty lines
tcberner updated this revision to Diff 29892.Jun 21 2017, 9:28 AM

Switch to qmake:outsource.

tcberner updated this revision to Diff 29899.Jun 21 2017, 10:07 AM

Don't bump revision in qt5-qtpaths (pkg-descr change is very minor).
[Note, I will commit this one separately, it just also had the same issues tht were critized for the new ones].

rakuco accepted this revision.Jun 21 2017, 10:23 AM

I'd land the changes to qt5-qtpaths separately and focus on the new ports when referencing this diff in the commit.

mat added inline comments.Jun 21 2017, 10:49 AM
sysutils/qt5-qtpaths/Makefile
22 ↗(On Diff #29899)

empty line before here too.

tcberner updated this revision to Diff 29905.Jun 21 2017, 11:07 AM
tcberner edited edge metadata.

Empty line.

tcberner updated this revision to Diff 29919.Jun 21 2017, 6:01 PM
  • qt5-qtpaths has been commited.
rakuco accepted this revision.Jun 21 2017, 6:04 PM

shipit!

This revision was automatically updated to reflect the committed changes.