mail/alpine: clean up and modernize Makefile

[ultima]

Summary

• Removed options SSL, ISPELL, NOSPELL
• Added option ASPELL set as default
• Modernized makefile

PR\: 219895
Sumitted by\: Marco Beishuizen <[e-mail]> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: [84]: use ${VARIABLE}, instead of $(VARIABLE). (false pos)
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. (option default false pos)
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. (false pos)
WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=", not by "?=". (is master port)
WARN: Makefile: new ports should not set PORTREVISION. (not new port)
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=". (is master port)
WARN: /usr/home/ricky/FreeBSD/ports/mail/alpine/distinfo: [1]: TIMESTAMP is over 30 days old (not really an issue?)
0 fatal errors and 7 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[lifanov]

You can make small changes to the submission.
For example, at least this needs to be fixed:

WARN: Makefile: [84]: use ${VARIABLE}, instead of $(VARIABLE).

[mat]

mail/alpine/Makefile

34–35 ↗

(On Diff #29787)

I guess this is a slave port.

When options should not be enabled for slave ports, it usually means that they should be disabled. So options should always be in OPTIONS_DEFINE, and options that are to be excluded for a slave should be in OPTIONS_EXCLUDE, to make sure they are off and not simply ignored.

107–114 ↗

(On Diff #29787)

Variables should always be defined *before* any target.

[ultima]

This is actually a master port, editors/pico-alpine is the slave.

[mat]

Yes, yes (heat wave in Paris, brain melting) but you get the point :-)

[ultima]

In D11263#232947, @lifanov wrote:

You can make small changes to the submission.
For example, at least this needs to be fixed:

WARN: Makefile: [84]: use ${VARIABLE}, instead of $(VARIABLE).

I forgot to make comment on the portlint items, most are false positives if not all.

[ultima]

In D11263#232998, @mat wrote:

Yes, yes (heat wave in Paris, brain melting) but you get the point :-)

Heh, as many mistakes as I made last night, I just assumed that I made another one. >.<

[lifanov]

I personally don't mess with things like these:

.if defined(PICO_ALPINE_SLAVE)
OPTIONS_EXCLUDE=        CONS25 IPV6 LDAP MAILDIR PASSFILE
.endif

and just put the overrides in the slave port directly, but this is fine.

Looks good to me!