Fix some LinuxKPI namespace pollution.
ClosedPublic
Actions

Authored by markj on Jun 17 2017, 10:55 PM.

Details

Reviewers

Commits

rS320072: Avoid including list.h in LinuxKPI headers.

Summary

Avoid including wait.h and list.h unless they are actually needed.
list.h pulls in a number of FreeBSD headers that contribute to some
namespace collisions that I've been encountering.

Test Plan

make buildkernel WITH_OFED=

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 17 2017, 10:55 PM

Herald added a subscriber: emaste. · View Herald TranscriptJun 17 2017, 10:55 PM

Harbormaster completed remote builds in B9950: Diff 29761.Jun 17 2017, 10:55 PM

markj edited the test plan for this revision. (Show Details)Jun 17 2017, 10:56 PM

markj added a reviewer: • hselasky.

Looks good.

This revision is now accepted and ready to land.Jun 18 2017, 10:00 AM

Closed by commit rS320072: Avoid including list.h in LinuxKPI headers. (authored by markj). · Explain WhyJun 18 2017, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

1 line

1 line

1 line

1 line

1 line

contrib/

rdma/

krping/

krping.c

1 line

ofed/

drivers/

infiniband/

core/

fmr_pool.c

1 line

iwcm.c

1 line

umem.c

1 line

hw/

mthca/

mthca_dev.h

1 line

Diff 29788

View Options

head/sys/compat/linuxkpi/common/include/linux/completion.h

View Options

head/sys/compat/linuxkpi/common/include/linux/kernel.h

View Options

head/sys/compat/linuxkpi/common/include/linux/kobject.h

View Options

head/sys/compat/linuxkpi/common/include/linux/mm_types.h

View Options

head/sys/compat/linuxkpi/common/include/linux/sched.h

View Options

head/sys/contrib/rdma/krping/krping.c

View Options

head/sys/ofed/drivers/infiniband/core/fmr_pool.c

View Options

head/sys/ofed/drivers/infiniband/core/iwcm.c

View Options

head/sys/ofed/drivers/infiniband/core/umem.c

View Options

head/sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h

Fix some LinuxKPI namespace pollution.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29788

head/sys/compat/linuxkpi/common/include/linux/completion.h

head/sys/compat/linuxkpi/common/include/linux/kernel.h

head/sys/compat/linuxkpi/common/include/linux/kobject.h

head/sys/compat/linuxkpi/common/include/linux/mm_types.h

head/sys/compat/linuxkpi/common/include/linux/sched.h

head/sys/contrib/rdma/krping/krping.c

head/sys/ofed/drivers/infiniband/core/fmr_pool.c

head/sys/ofed/drivers/infiniband/core/iwcm.c

head/sys/ofed/drivers/infiniband/core/umem.c

head/sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h

Fix some LinuxKPI namespace pollution.
ClosedPublic
Actions

Revision Contents
Changeset List