audio/sox: Add SNDIO option and make enabling the sndio backend explicit
ClosedPublic
Actions

Authored by tobik on Jun 15 2017, 8:20 PM.

Details

Reviewers

lme
mat

Commits

rP443710: - Add SNDIO option and make enabling the sndio backend explicit. It's

Summary

- Add SNDIO option and make enabling the sndio backend explicit.  It's
  currently automatically enabled when sndio is available in the build
  environment.
- Add a OSS default option, so that the OSS backend can be turned off
  if desired.
- Since there are a lot of audio backend options, group them to make
  the config dialog more readable.
- USES=localbase:ldflags

  PR:		219998
  Approved by:	??? (mentor), Dan Nelson <dnelson@allantgroup.com> (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D?????

Test Plan

poudriere testport 11.0/amd64 ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobik created this revision.Jun 15 2017, 8:20 PM

dnelson_1901_yahoo.com added a subscriber: dnelson_1901_yahoo.com.Jun 15 2017, 8:28 PM

mat accepted this revision.Jun 16 2017, 12:07 PM

mat added inline comments.

audio/sox/Makefile
80 ↗	(On Diff #29682)	Id oss has no additional dependencies, maybe it should not be optional?

This revision is now accepted and ready to land.Jun 16 2017, 12:07 PM

tobik added inline comments.Jun 16 2017, 3:29 PM

audio/sox/Makefile
80 ↗	(On Diff #29682)	True, but it's nice to be able to turn it off anyway. Either for debugging or maybe you don't want to have any audio backend at all.

Closed by commit rP443710: - Add SNDIO option and make enabling the sndio backend explicit. It's (authored by tobik). · Explain WhyJun 16 2017, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

audio/

sox/

Makefile

20 lines

Diff 29722

View Options

audio/sox: Add SNDIO option and make enabling the sndio backend explicitClosedPublicActions