Page MenuHomeFreeBSD

kerberos5/lib/libkrb5 more build warning fixes
Needs ReviewPublic

Authored by aprieger_llnw.com on Jun 14 2017, 11:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 2:03 AM
Unknown Object (File)
Dec 20 2023, 2:49 AM
Unknown Object (File)
Nov 18 2023, 8:03 AM
Unknown Object (File)
Nov 18 2023, 7:59 AM
Unknown Object (File)
Nov 18 2023, 6:29 AM
Unknown Object (File)
Sep 29 2023, 6:02 PM
Unknown Object (File)
May 4 2023, 4:39 PM
Unknown Object (File)
Dec 23 2022, 7:49 PM
Subscribers
None

Details

Reviewers
kbowling
sbruno
Summary

Code changes to fix warnings during build time for the application in the kerberos5/lib/libkrb5 folder

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9889
Build 10324: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/c8047fba03cfbb54bb5a46560679471c

  1. crypto/heimdal/lib/krb5/init_creds_pw.c
    • warning: taking the absolute value of unsigned type 'LR_TYPE' (aka 'enum LR_TYPE') has no effect [-Wabsolute-value]
      • fix: added the signed modifier to change the unsigned parameter in the switch to allow it to be taken the absolute value of on line 314
      • note: simply removing the absolute value function causes more warnings calling for the unhandled enumeration values for the switch
  2. crypto/heimdal/lib/krb5/ticket.c
    • warning: format specifies type 'int' but the argument has type 'long' [-Wformat]
      • fix: added the (int) explicit modifier to the parameter on line 783