Page MenuHomeFreeBSD

security/rkhunter: Remove www/wget dependency
ClosedPublic

Authored by ultima on Jun 12 2017, 10:17 PM.

Details

Summary
  • Add fetch function to rkhunter
  • Remove wget as a dependency
  • Added NO_ARCH
  • Fixed portlint items

PR\: 219825
Sumitted by\: Helge Oldach <freebsd@oldach.net>
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: Lukasz Wasikowski <lukasz@wasikowski.net> (maintainer), lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Looks like this port could be marked as architecture independent.

=======================<phase: package        >============================
===>  Building package for rkhunter-1.4.2_4
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:11:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?
file sizes/checksums    [42]: . done
packing files           [42]: . done
packing directories      [7]: . done

Apart from that, everything looks good.

This revision is now accepted and ready to land.Jun 13 2017, 7:08 AM

Looks like this port could be marked as architecture independent.

=======================<phase: package        >============================
===>  Building package for rkhunter-1.4.2_4
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:11:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?
file sizes/checksums    [42]: . done
packing files           [42]: . done
packing directories      [7]: . done

Apart from that, everything looks good.

Is maintainer approval required for adding NO_ARCH=yes?

Looks like this port could be marked as architecture independent.

=======================<phase: package        >============================
===>  Building package for rkhunter-1.4.2_4
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:11:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?
file sizes/checksums    [42]: . done
packing files           [42]: . done
packing directories      [7]: . done

Apart from that, everything looks good.

Is maintainer approval required for adding NO_ARCH=yes?

I think this should be checked with the maintainer. Technically there are portmgr blanket approvals for infrastructure type changes (but
setting NO_ARCH=yes is pretty borderline though.) It's always good to check back with the maintainer even if you don't have to.

You absolutely do not need to ask the maintainer to add NO_ARCH.

Please read section [[ http://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html | 5.5. MAINTAINER ]] of the Porter's Handbook. Especially the:

We reserve the right to modify the maintainer's submission to better match existing policies and style of the Ports Collection without explicit blessing from the submitter or the maintainer.

Of course, if you want to ask permission for a change, you can, you just do not have to.

ultima edited edge metadata.
  • added NO_ARCH
  • Fixed portlint items
This revision now requires review to proceed.Jun 13 2017, 8:57 PM
ultima edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 13 2017, 10:21 PM
This revision was automatically updated to reflect the committed changes.