Page MenuHomeFreeBSD

Add a port for netdumpd
ClosedPublic

Authored by markj on Jun 12 2017, 9:43 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I'd like to only build this for 11.x and 12, since it depends on libcasper. What's the right way to enforce that?

I'd like to only build this for 11.x and 12, since it depends on libcasper. What's the right way to enforce that?

The new fancy way is IGNORE_FreeBSD_10= no libcasper support (wording up to you). Since anything before 10 is EOL already you don't need to worry about them.

Looks fine, with the distinfo issue fixed. Approved (be sure to note that since you are not a ports committer)

ftp/netdumpd/distinfo
1 ↗(On Diff #29514)

Can you run make makesum in the tree please? There's a missing _TIMESTAMP_ field here that is for some reproducibility work.

This revision is now accepted and ready to land.Jun 12 2017, 10:01 PM
markj edited edge metadata.
  • Address review comments.
This revision now requires review to proceed.Jun 12 2017, 10:05 PM
This revision is now accepted and ready to land.Jun 12 2017, 10:06 PM

Btw usually new ports are committed with their full pkg-descr on line 2+

This revision was automatically updated to reflect the committed changes.