Paths

Table of Contentst

Differential D11145

ext2fs: Put ext2fs acl functionality inside UFS_ACL definition
ClosedPublic
Actions

Authored by fsu on Jun 11 2017, 3:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 12:28 PM

	Unknown Object (File)
	Sun, Oct 27, 10:51 AM

	Unknown Object (File)
	Thu, Oct 24, 2:40 PM

	Unknown Object (File)
	Oct 14 2024, 6:26 AM

	Unknown Object (File)
	Oct 3 2024, 8:08 AM

	Unknown Object (File)
	Sep 24 2024, 12:11 AM

	Unknown Object (File)
	Sep 13 2024, 8:54 AM

	Unknown Object (File)
	Sep 12 2024, 9:25 PM

View All 27 Files

Subscribers

Details

Reviewers

Commits

rS319827: extfs: fix the build with no UFS_ACL.

Summary

Need to fix ext2fs module build in case UFS_ACL is not defined.

Test Plan

None.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fsu created this revision.Jun 11 2017, 3:52 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 11 2017, 3:52 PM

Haven't compile-tested yet ...
/* !UFS_ACL */ is wrong in these cases.

sys/fs/ext2fs/ext2_acl.c
528 ↗	(On Diff #29463)	The comment is wrong: we only use the negation when there is an associated `#ifndef`
sys/fs/ext2fs/ext2_extattr.c
92 ↗	(On Diff #29463)	This is unrelated to the revision topic. The comment is not needed in this case since the code is so short (an obvious).

This revision now requires changes to proceed.Jun 11 2017, 6:42 PM

BTW.. don't waste time updating this.. the changes are trivial so I will just do them locally.

This revision is now accepted and ready to land.Jun 11 2017, 7:00 PM

Ok, thanks you for my mistakes fixing.

sys/fs/ext2fs/ext2_extattr.c
92 ↗	(On Diff #29463)	Yep, it is cheating from side:) it should be fixed in previous diff, Ok, I will fix it later, do not commit it now please.

Closed by commit rS319827: extfs: fix the build with no UFS_ACL. (authored by pfg). · Explain WhyJun 11 2017, 7:05 PM

This revision was automatically updated to reflect the committed changes.

pfg added inline comments.Jun 11 2017, 7:20 PM

sys/fs/ext2fs/ext2_extattr.c
92 ↗	(On Diff #29463)	Sorry ... fixed it in r319829 (before reading this).

Ok, let's leave it as is for now.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

ext2fs/

4 lines

14 lines

Diff 29466

head/sys/fs/ext2fs/ext2_acl.c

Loading...

head/sys/fs/ext2fs/ext2_vnops.c

Loading...