Page MenuHomeFreeBSD
Differential D11131

uuencode(1): Capsicumify
AbandonedPublic
Actions

Authored by bkidney_briankidney.ca on Jun 10 2017, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 6:45 PM
Unknown Object (File)
Fri, Dec 6, 3:32 AM
Unknown Object (File)
Nov 25 2024, 7:24 AM
Unknown Object (File)
Nov 23 2024, 12:53 AM
Unknown Object (File)
Nov 22 2024, 11:19 AM
Unknown Object (File)
Nov 21 2024, 4:28 PM
Unknown Object (File)
Nov 21 2024, 4:27 PM
Unknown Object (File)
Nov 16 2024, 4:06 PM
View All Files
Subscribers
bdrewery

Details

Reviewers
allanjude
emaste
Test Plan
  • uuencode stdin -> stdout
  • uuencode file -> stdout
  • uuencode stdin -> file
  • uuencode file -> file
  • uuencode pipe -> stdout

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9785
Build 10222: arc lint + arc unit

Event Timeline

bkidney_briankidney.ca created this revision.Jun 10 2017, 4:51 PM
Harbormaster completed remote builds in B9774: Diff 29417.Jun 10 2017, 4:51 PM
bkidney_briankidney.ca updated this revision to Diff 29420.Jun 10 2017, 5:08 PM
  • Fixes the indentation to use tabs.
Herald added a subscriber: bdrewery. · View Herald TranscriptJun 10 2017, 5:08 PM
Harbormaster completed remote builds in B9777: Diff 29420.Jun 10 2017, 5:08 PM
bkidney_briankidney.ca updated this revision to Diff 29423.Jun 10 2017, 5:13 PM

Removing unncessary file.

Harbormaster completed remote builds in B9780: Diff 29423.Jun 10 2017, 5:13 PM
emaste accepted this revision.Jun 10 2017, 6:00 PM
emaste added inline comments.
usr.bin/uuencode/uuencode.c
141

maybe just "Failed to limit stdio"?

This revision is now accepted and ready to land.Jun 10 2017, 6:00 PM
bkidney_briankidney.ca updated this revision to Diff 29436.Jun 10 2017, 6:11 PM
bkidney_briankidney.ca edited edge metadata.

Updates error message based on feedback.

This revision now requires review to proceed.Jun 10 2017, 6:11 PM
Harbormaster completed remote builds in B9785: Diff 29436.Jun 10 2017, 6:11 PM
bkidney_briankidney.ca marked an inline comment as done.Jun 10 2017, 6:12 PM
emaste accepted this revision.Jun 10 2017, 8:26 PM

This diff (and previous ones) seem to be relative to the last upload, not the upstream version - please diff against upstream for future uploads. But, comparing the final result in this review with what's in HEAD it looks good to me.

This revision is now accepted and ready to land.Jun 10 2017, 8:26 PM
bkidney_briankidney.ca abandoned this revision.Jun 9 2018, 2:15 AM

Revision Contents
Changeset List

PathSize
usr.bin/
uuencode/
2 lines

Diff 29436

View Options

usr.bin/uuencode/uuencode.c

Loading...