Page MenuHomeFreeBSD
Differential D11089

New port committer: ultima
ClosedPublic
Actions

Authored by ultima on Jun 8 2017, 12:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 23 2024, 12:39 AM
Unknown Object (File)
Nov 5 2024, 12:00 AM
Unknown Object (File)
Oct 5 2024, 7:38 PM
Unknown Object (File)
Oct 5 2024, 11:47 AM
Unknown Object (File)
Oct 4 2024, 10:49 PM
Unknown Object (File)
Oct 4 2024, 9:44 PM
Unknown Object (File)
Oct 4 2024, 5:56 PM
Unknown Object (File)
Oct 4 2024, 4:34 PM
View All 46 Files
Subscribers
imp

Details

Reviewers
lifanov
matthew
Commits
rS319674: Add myself (ultima) as a new port committer.
Summary

Add myself (ultima) as a new port committer.

Reviewed by\: matthew (mentor), lifanov (mentor)
Approved by\: matthew (mentor), lifanov (mentor)
Differential Revision\: https://reviews.freebsd.org/D11089

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ultima created this revision.Jun 8 2017, 12:38 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 8 2017, 12:38 AM
matthew accepted this revision.Jun 8 2017, 12:41 AM

LGTM

This revision is now accepted and ready to land.Jun 8 2017, 12:41 AM
lifanov accepted this revision.Jun 8 2017, 12:42 AM

Looks great!

lifanov requested changes to this revision.Jun 8 2017, 12:46 AM

Please include the intended commit message in the summary field.
The default Subversion commit template should be filled out with these:

Reviewed by:
Approved by:
Differential Revision:

This revision now requires changes to proceed.Jun 8 2017, 12:46 AM
ultima edited the summary of this revision. (Show Details)Jun 8 2017, 12:58 AM
ultima added a comment.Jun 8 2017, 1:02 AM

The site, reviews.freebsd.org won't allow ":" in summery. I plan to move to arcanist, but it is being built atm.

lifanov added a comment.Jun 8 2017, 1:15 AM

The reviewed/approved fields take FreeBSD project usernames, so these should look like so:

Reviewed by: matthew (mentor), lifanov (mentor)
ultima edited the summary of this revision. (Show Details)Jun 8 2017, 1:22 AM
lifanov added a comment.Jun 8 2017, 1:26 AM

The usernames need to be lowercase. So, "matthew", not "Matthew"

ultima edited the summary of this revision. (Show Details)Jun 8 2017, 1:30 AM
lifanov accepted this revision.Jun 8 2017, 1:31 AM

Looks great!

This revision is now accepted and ready to land.Jun 8 2017, 1:31 AM
Closed by commit rS319674: Add myself (ultima) as a new port committer. (authored by ultima). · Explain WhyJun 8 2017, 1:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
share/
misc/
4 lines
usr.bin/
calendar/
calendars/
1 line

Diff 29315

View Options

head/share/misc/committers-ports.dot

Loading...
View Options

head/usr.bin/calendar/calendars/calendar.freebsd

Loading...