Page MenuHomeFreeBSD

kerberos5/lib/libkdc build warning fixes
Needs ReviewPublic

Authored by aprieger_llnw.com on Jun 5 2017, 6:34 PM.
Tags
None
Referenced Files
F168452685: D11063.id.diff
Fri, Aug 28, 11:18 AM
F168392533: D11063.id.diff
Thu, Aug 27, 11:46 PM
Unknown Object (File)
Wed, Aug 26, 12:48 PM
Unknown Object (File)
Tue, Aug 25, 3:29 PM
Unknown Object (File)
Tue, Aug 25, 3:27 PM
Unknown Object (File)
Tue, Aug 25, 12:51 AM
Unknown Object (File)
Mon, Aug 24, 1:30 PM
Unknown Object (File)
Mon, Aug 24, 1:27 PM
Subscribers
None

Details

Reviewers
kbowling
sbruno
Summary

kerberos5/lib/libkdc build time warning fixes

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9679
Build 10119: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings are at: https://github.llnw.net/gist/aprieger/fc51f108152d4ef69f5c

  1. crypto/heimdal/kdc/digest.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 608
  2. crypto/heimdal/kdc/kerberos5.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 1299 and 1310
  3. crypto/heimdal/kdc/pkinit.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 104 and 126