Page MenuHomeFreeBSD

kerberos5/lib/libkdc build warning fixes
Needs ReviewPublic

Authored by aprieger_llnw.com on Jun 5 2017, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 23, 12:45 AM
Unknown Object (File)
Wed, May 20, 1:54 PM
Unknown Object (File)
May 17 2026, 4:44 AM
Unknown Object (File)
May 17 2026, 4:44 AM
Unknown Object (File)
May 6 2026, 7:11 PM
Unknown Object (File)
May 6 2026, 11:58 AM
Unknown Object (File)
May 5 2026, 12:56 PM
Unknown Object (File)
Apr 21 2026, 12:36 AM
Subscribers
None

Details

Reviewers
kbowling
sbruno
Summary

kerberos5/lib/libkdc build time warning fixes

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9679
Build 10119: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings are at: https://github.llnw.net/gist/aprieger/fc51f108152d4ef69f5c

  1. crypto/heimdal/kdc/digest.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 608
  2. crypto/heimdal/kdc/kerberos5.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 1299 and 1310
  3. crypto/heimdal/kdc/pkinit.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 104 and 126