Kill @ symlink
ClosedPublic
Actions

Authored by imp on Nov 3 2014, 4:45 PM.

Details

Reviewers: None
Commits: rS274184: Retire the '@' symlink. It isn't really needed and causes more

Summary

Replace the @ symlink in builds with ${SYSDIR} and conditionally set
${SYSDIR} in the one place where it seems to matter.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

imp updated this revision to Diff 2254.Nov 3 2014, 4:45 PM

imp retitled this revision from to Kill @ symlink.

imp updated this object.

imp edited the test plan for this revision. (Show Details)

While it's not the described point of the diff, I noticed a missed opportunity to use ${SYSDIR} in sys/modules/svr4/Makefile in the .PATH definition.

In D1100#2, @brooks wrote:

While it's not the described point of the diff, I noticed a missed opportunity to use ${SYSDIR} in sys/modules/svr4/Makefile in the .PATH definition.

Yes. That turns out to be a problem, not only there, but from the other places I did it. It isn't defined in the world / single module case, so make winds up not being able to find the header files, which is why I did the SYSDIR ?= bit where I did the substitution. Rather than propagate that widely, I thought I'd try to be minimal about it.