Differential D10959

Update the comment for the rootpath
ClosedPublic
Actions

Authored by bapt on May 27 2017, 3:01 PM.

Tags

None

Referenced Files

	F153282366: D10959.id.diff
	Mon, Apr 20, 5:48 AM

	Unknown Object (File)
	Fri, Apr 17, 3:26 PM

	Unknown Object (File)
	Fri, Apr 17, 3:18 PM

	Unknown Object (File)
	Wed, Apr 15, 9:02 AM

	Unknown Object (File)
	Tue, Apr 7, 1:50 AM

	Unknown Object (File)
	Mon, Apr 6, 11:05 PM

	Unknown Object (File)
	Mon, Apr 6, 1:51 PM

	Unknown Object (File)
	Mon, Mar 30, 3:57 AM

Subscribers

Details

Reviewers

Commits

rS318999: Update the comments concerning net_parse_rootpath to reflect what it is now

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.May 27 2017, 3:01 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2017, 3:01 PM

rgrimes added inline comments.May 27 2017, 4:52 PM

sys/boot/common/dev_net.c
376 ↗	(On Diff #28911)	Better would be (as NFS scheme) -> as an NFS scheme.
380 ↗	(On Diff #28911)	Typo? ips -> ip
381 ↗	(On Diff #28911)	Missing end ). Actually in all of these comments I dont see that the parens add any value

Pet rgrimes comment + small rewording

Harbormaster completed remote builds in B9531: Diff 28912.May 27 2017, 6:36 PM

add a forgotten word

Harbormaster completed remote builds in B9532: Diff 28913.May 27 2017, 6:37 PM

bapt marked 3 inline comments as done.May 27 2017, 6:37 PM

bapt added inline comments.

sys/boot/common/dev_net.c
381 ↗	(On Diff #28911)	actually reworded a bit

I think this should do nicely.

This revision is now accepted and ready to land.May 27 2017, 6:40 PM

Closed by commit rS318999: Update the comments concerning net_parse_rootpath to reflect what it is now (authored by bapt). · Explain WhyMay 27 2017, 6:46 PM

This revision was automatically updated to reflect the committed changes.

bapt marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

common/

16 lines

Diff 28914

head/sys/boot/common/dev_net.c

Loading...