Page MenuHomeFreeBSD

libthr: prevent setcontext() from masking SIGTHR
ClosedPublic

Authored by vangyzen on May 26 2017, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 15, 5:08 PM
Unknown Object (File)
Mon, May 11, 6:04 PM
Unknown Object (File)
Mon, May 11, 4:25 PM
Unknown Object (File)
Sun, May 10, 4:37 PM
Unknown Object (File)
Sat, May 2, 10:30 AM
Unknown Object (File)
Wed, Apr 22, 5:35 PM
Unknown Object (File)
Apr 9 2026, 1:57 AM
Unknown Object (File)
Apr 6 2026, 4:00 PM
Subscribers

Details

Summary

__thr_setcontext() mistakenly tested for the presence of SIGCANCEL
in its local ucontext_t instead of the parameter. Therefore,
if a thread calls setcontext() with a context whose signal mask
contains SIGTHR (a.k.a. SIGCANCEL), that signal will be blocked,
preventing the thread from being cancelled or suspended.

Reported by: gcc 6.1 via RISC-V tinderbox

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/libthr/thread/thr_sig.c
740 ↗(On Diff #28854)

Fix style of the next line as well, add ().

This revision is now accepted and ready to land.May 26 2017, 3:36 PM
This revision was automatically updated to reflect the committed changes.