Page MenuHomeFreeBSD
Differential D1078

Change linux faccessat syscall definition to match actual linux one.
ClosedPublic
Actions

Authored by dchagin on Nov 2 2014, 10:06 PM.
Tags
None
Referenced Files
F149001220: D1078.id2224.diff
Sat, Mar 21, 4:30 PM
Unknown Object (File)
Thu, Mar 19, 3:19 AM
Unknown Object (File)
Wed, Mar 18, 4:21 AM
Unknown Object (File)
Sun, Mar 15, 3:19 PM
Unknown Object (File)
Wed, Mar 11, 1:08 PM
Unknown Object (File)
Sat, Mar 7, 4:49 AM
Unknown Object (File)
Sun, Mar 1, 6:45 PM
Unknown Object (File)
Sun, Mar 1, 6:33 PM
View All Files
Subscribers
imp
trasz

Details

Reviewers
trasz
Group Reviewers
Linux Emulation
Commits
rS283428: Change linux faccessat syscall definition to match actual linux one.
Summary

The AT_EACCESS and AT_SYMLINK_NOFOLLOW flags are actually implemented
within the glibc wrapper function for faccessat(). If either of these
flags are specified, then the wrapper function employs fstatat() to
determine access permissions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 2224.Nov 2 2014, 10:06 PM
dchagin retitled this revision from to Change linux faccessat syscall definition to match actual linux one..
dchagin updated this object.
dchagin added a reviewer: Linux Emulation.Nov 2 2014, 10:18 PM
trasz added a subscriber: trasz.Mar 21 2015, 4:53 PM
trasz added inline comments.
sys/compat/linux/linux_file.c
601 ↗(On Diff #2224)

Get rid of flag variable and pass AT_EACCESS directly, perhaps?

dchagin updated this revision to Diff 4417.Mar 25 2015, 6:58 PM

whoops, yes, faccessat() as access() here use the real uid/gid.

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2015, 6:58 PM
trasz accepted this revision.Mar 27 2015, 9:43 AM
trasz added a reviewer: trasz.
This revision is now accepted and ready to land.Mar 27 2015, 9:43 AM
Closed by commit rS283428: Change linux faccessat syscall definition to match actual linux one. (authored by dchagin). · Explain WhyMay 24 2015, 4:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
linux/
2 lines
linux32/
3 lines
compat/
linux/
7 lines
i386/
linux/
3 lines

Diff 5636

View Options

head/sys/amd64/linux/syscalls.master

Loading...
View Options

head/sys/amd64/linux32/syscalls.master

Loading...
View Options

head/sys/compat/linux/linux_file.c

Loading...
View Options

head/sys/i386/linux/syscalls.master

Loading...