Because the datasets are already mounted by zfsboot, and the mount script
doesn't know anything about ZFS. Also do not execute the "umount" script for
ZFS for the same reasons.
Sponsored by: Citrix Systems R&D
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I do not know much about bsdinstall scripts but as much as it counts, seems ok for me;)
| usr.sbin/bsdinstall/scripts/script | ||
|---|---|---|
| 44 ↗ | (On Diff #28524) | Add here: #
# Default name of the boot-pool
#
: ${ZFSBOOT_POOL_NAME:=zroot} |
| 64 ↗ | (On Diff #28524) | Simplify to: [ -f "$PATH_FSTAB" ] || exit Note: When exit is not given an argument, it returns the previous exit status (which would be the error-status from the "[ -f ... ]" command to the left of the "or" |
| 66 ↗ | (On Diff #28524) | Delete this line (see inline comment in CONFIGURATION section) |
| 138 ↗ | (On Diff #28524) | Delete this line (see inline comment in CONFIGURATION section) |
Comment Actions
Thanks for the review, I've fixed the comments and I would like to push this ASAP, since it will allow me to build FreeBSD install images on the Xen CI loop without any external patches. Long term I think it would be better to add an "unmount" argument to zfsboot, but that can be done later.
Can I also have your opinion on D10736? That's the other one that's required for me.